Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new module for direct-load. #94

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

yuanoOo
Copy link
Member

@yuanoOo yuanoOo commented Oct 9, 2024

Summary

closes #93

Solution Description

@yuanoOo yuanoOo requested a review from whhe October 9, 2024 08:11
Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming is really a problem. My current idea is to use ' oceanbase-directload' as both the identifier and the module name. Do you have any ideas? If you don't have any preference, we can merge it first and make a decision before releasing.

pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@whhe whhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whhe whhe merged commit a461a20 into oceanbase:main Oct 10, 2024
4 checks passed
@yuanoOo yuanoOo deleted the direct-load-module branch January 7, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[subtask]: Add a new module for direct-load.
2 participants