-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Node bindings for public use #1621
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sacha Ayoun <[email protected]>
Wouldn't it be better to put this in a separate package? |
I created its own package at first, but I was thinking that there are already two attempts at binding node from ocaml (here and here), and if one wants to ever publish one of those on opam, this could still be published under vscode.node. The advantage and that someone writing bindings for vscode would know these bindings interact well since they are actively used here. |
The main advantage of having a separate package is that users of this library will not need to build and install a bunch of unrelated stuff we use just for vscode. You could call the package |
Hmm, the issue is that |
You could put it under |
It's used for:
|
I see. |
Signed-off-by: Sacha Ayoun <[email protected]>
Signed-off-by: Sacha Ayoun <[email protected]>
Alright done :) And it works on my machine |
Hello,
I'm using this, your bindings are actually pretty helpful! I do need the Node bindings that are not yet expose, so I forked it, but I thought it might as well be merged.