Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html manual links changed from inria website to ocaml.org #1574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

html manual links changed from inria website to ocaml.org #1574

wants to merge 1 commit into from

Conversation

gurleennsidhuu
Copy link
Contributor

@gurleennsidhuu gurleennsidhuu commented Apr 30, 2021

Issue Description

in the releases directory, the *refman.html, *.refman-html.zip, and refman-html.tar.gz files point to the INRIA
website in the sentence

"This manual is also available in PDF. plain text, as a bundle of HTML files, and as a bundle of Emacs Info files."

instead of pointing to ocaml.org.

Fixes #1131

Changed all the links in the above listed files from inria website to ocaml.org.

@gurleennsidhuu
Copy link
Contributor Author

I hope I understood the issue correctly. If not, I would love to make the required changes.

@avsm
Copy link
Member

avsm commented May 1, 2021

This looks good to me. @Octachron are you ok with the historical manual links being changed?

Copy link
Member

@Octachron Octachron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am perfectly ok with updating html files.

There is however an issue with the *.tar.gz file: their size is increasing with a factor between 5 and 13.

Which brings me to the issue of reproducibility: it seems to me that it would be more maintainable (and safer) if we had a script to recreate the compressed archive from the html source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html manuals still link to inria website instead of ocaml.org
3 participants