-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify documentation for enable
pseudo-variable
#5659
Open
gridbugs
wants to merge
3
commits into
ocaml:master
Choose a base branch
from
gridbugs:enable-doc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Sep 11, 2023
The documentation for variables says that for boolean variables the form `name1+name2+name3:var` is equivalent to `name1:var & name2:var & name3:var` but it's possible to write `name1+name2:enable` despite `enable` being the string "enable" or "disable". This change clarifies that `enable` isn't really a variable but syntactic sugar instead.
kit-ty-kate
force-pushed
the
enable-doc
branch
from
September 11, 2023 12:01
efff965
to
0b84e2e
Compare
kit-ty-kate
approved these changes
Sep 11, 2023
rjbou
reviewed
Sep 11, 2023
test in #5642 updated |
rjbou
requested changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed a rewording. The combination part is a specific note on enabled
variable usage with combination; It should be put after the definition.
Co-authored-by: R. Boujbel <[email protected]>
gridbugs
commented
Sep 30, 2024
kit-ty-kate
reviewed
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for variables says that for boolean variables the form
name1+name2+name3:var
is equivalent toname1:var & name2:var & name3:var
but it's possible to writename1+name2:enable
despiteenable
being the string "enable" or "disable". This change clarifies thatenable
isn't really a variable but syntactic sugar instead.