Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "make cold" on Windows when gcc is available #5635

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Aug 15, 2023

Partially f.i.x.e.s. #5628
Fixes #5600

@rjbou rjbou added this to the 2.2.0~alpha3 milestone Aug 18, 2023
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing it, seems ok from my perspective

@rjbou rjbou force-pushed the fix-windows-build-gcc-present branch from 1fd0bc0 to 7245d92 Compare August 18, 2023 09:07
@kit-ty-kate kit-ty-kate merged commit f0fccbc into ocaml:master Aug 22, 2023
26 checks passed
@kit-ty-kate kit-ty-kate deleted the fix-windows-build-gcc-present branch August 22, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make cold on Windows: flexlink error
2 participants