-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4 packages from gitlab.com/nomadic-labs/data-encoding/-/archive/v1.0.0/data-encoding-v1.0.0.tar.gz #23475
4 packages from gitlab.com/nomadic-labs/data-encoding/-/archive/v1.0.0/data-encoding-v1.0.0.tar.gz #23475
Conversation
The CI errors with tezos*.15* packages (see example below) happen because:
I've added a commit to mark this incompatibility. I think it'll prevent installing tezos15 with json-data-encoding.1.0.0 completely.
|
958d2b9
to
92d9868
Compare
…0/data-encoding-v1.0.0.tar.gz
92d9868
to
48ea14b
Compare
There is a pervasive test failure:
|
I've updated the tag to include the fix written by @raphael-proust in https://gitlab.com/nomadic-labs/data-encoding/-/merge_requests/124/diffs?commit_id=a025e43339402b05b9a637b0754eaabef5ef0f42, but I can't update this PR. @raphael-proust is out this week. alternatively I can open a new PR.
|
Will do right away |
packages/json-data-encoding-browser/json-data-encoding-browser.1.0.0/opam
Outdated
Show resolved
Hide resolved
packages/json-data-encoding-bson/json-data-encoding-bson.1.0.0/opam
Outdated
Show resolved
Hide resolved
There are lots of failures of the type:
and
Can you add the relevant upper bounds? |
I readded the patch which marks conflicts. It had disappeared probably during the tag update or something. I've also upstreamed this to our v1 branch so it won't get lost. |
All remaining errors seem to be during installation of deps or revdeps. |
Currently fails hard because of gitlab tarballing bug. See #23589 (comment) for some details. |
The gitlab issue seems to have been resolved. I'm restarting the jobs and retagging the PR. |
I think this can now be merged. The remaining errors look unrelated. |
This pull-request concerns:
data-encoding.1.0.0
: Library of JSON and binary encoding combinatorsjson-data-encoding.1.0.0
: Type-safe encoding to and decoding from JSONjson-data-encoding-browser.1.0.0
: Type-safe encoding to and decoding from JSON (browser support)json-data-encoding-bson.1.0.0
: Type-safe encoding to and decoding from JSON (bson support)🐫 Pull-request generated by opam-publish v2.2.0