Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone markdown support #1234

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Standalone markdown support #1234

merged 8 commits into from
Nov 13, 2024

Conversation

jonludlam
Copy link
Member

This PR adds a new package, odoc-md, that can process markdown files and output page-*.odoc files to be linked and then turned into HTML/man/whatever by odoc. It's based on previous work by @dbuenzli and @panglesd, but is more limited in scope. There is no support for odoc-style references in markdown, as the main intent is to be able to render the various markdown-formatted files that voodoo currently does for ocaml.org (e.g. https://ocaml.org/p/odoc/latest/README.md.html).

odoc-md is based on cmarkit, which has an OCaml lower bound of 4.14, which is why this is a new package rather than part of the odoc package.

Copy link
Collaborator

@gpetiot gpetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nit-picking, but otherwise it looks good to me!
Maybe we could add a a cram test for the new binary.

README.md Outdated Show resolved Hide resolved
src/driver/odoc_unit.ml Outdated Show resolved Hide resolved
src/driver/odoc.ml Outdated Show resolved Hide resolved
src/markdown/odoc_md.ml Outdated Show resolved Hide resolved
src/markdown/odoc_md.ml Outdated Show resolved Hide resolved
@gpetiot
Copy link
Collaborator

gpetiot commented Nov 11, 2024

I imagine this will close #1213

@jonludlam jonludlam merged commit c1a6fde into ocaml:master Nov 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants