Improve dune runtest hints for non-test files #11108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiste
reviewed
Nov 12, 2024
maiste
approved these changes
Nov 12, 2024
Leonidas-from-XIV
approved these changes
Nov 14, 2024
|
@Leonidas-from-XIV There are two commits here. One where the test is added and another where the fix is done, showing how the test changes. |
|
@Alizter Ah, sorry, I somehow that this test was added in this PR. Thanks for the PR; LGTM. |
When running dune runtest on a file that is not a test, dune hints ``` Hint: did you mean <file> ``` even though the user just gave `<file>`. Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 8dd89353-d656-4214-89eb-0c692c4b5821 -->
When giving "Did you mean" hints, if our candidate list contains what the user wrote then this hint will not be helpful. This fixes a useless hint that was being given by dune runtest on non-test files. Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: c8d6099c-e98b-4e7f-a3a5-24d1dee04584 -->
Leonidas-from-XIV
force-pushed
the
fix-runtest-non-test
branch
from
cf6a781
to
a942b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When running dune runtest on a file that is not a test, dune hints
even though the user just gave
<file>.Fix
This stems from a deeper issue with
User_message.did_you_meanwhich accepts hints that are identical to the original name. It doesn't make sense to give a "did you mean" hint in the case they are identical, so we check that the Levenshtein distance is greater than 0.This removes the useless "did you mean" as observed in the tests.
We will improve the error message in a follow up PR.