pkg: Install all the dev-tools that are available #11032
Conversation
Signed-off-by: Alpha DIALLO <[email protected]>
moyodiallo
force-pushed
the
install-dev-tools
branch
from
8993d66
to
f515fa8
Compare
moyodiallo
force-pushed
the
install-dev-tools
branch
from
f515fa8
to
b92b7af
Compare
I would advocate for the opposite here. The aliases make sense when they are related to building targets in the context of Dune. Here, we are talking about development tools, so I'm afraid it would break the semantics as they are external tools. Also, in terms of accessibility, it would be easier for users to get access to the command than to the alias as with @gridbugs work, they have access to auto-completion. My recommendation would be to stick to the command instead of the alias, but in the end, it is just my opinion 😄 |
bin/lock_dev_tool.ml
Outdated
|
|
||
| let lock_tools (tools : Dune_pkg.Dev_tool.t list) = | ||
| List.map tools ~f:(function | ||
| | Dune_pkg.Dev_tool.Odoc -> lock_odoc () |
There was a problem hiding this comment.
Can you add a type annotation so this prefix is not needed?
| List.map dev_tools_path ~f:Action_builder.path |> Action_builder.all_unit) | ||
| in | ||
| match result with | ||
| | Error `Already_reported -> raise Dune_util.Report_error.Already_reported |
There was a problem hiding this comment.
I wonder, shouldn't this be Code_error.raise?
There was a problem hiding this comment.
If there is an error, it is already reported during the build and Code_error.raise is about raising with a message.
Signed-off-by: Alpha DIALLO <[email protected]>
moyodiallo
force-pushed
the
install-dev-tools
branch
from
b92b7af
to
6126ca9
Compare
This is supposed to close #11001.
But instead of having
dune tools installI wonder ifdune build @pkg-toolscould be a better alternative, because this is equivalent building/invoking some aliases.