Skip to content

Commit

Permalink
Merge pull request #1 from casparvl/pytorch_2.1.2_2023a_increase_max_…
Browse files Browse the repository at this point in the history
…failed_tests

Add hook to accept higher number of failing tests (10) for PyTorch on ARM
  • Loading branch information
bedroge authored Jan 24, 2024
2 parents 7ee64cd + 5ac329b commit dc7d306
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions eb_hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,15 @@ def pre_test_hook_ignore_failing_tests_SciPybundle(self, *args, **kwargs):
self.cfg['testopts'] = "|| echo ignoring failing tests"


def pre_test_hook_increase_max_failed_tests_arm_PyTorch(self, *args, **kwargs):
"""
Pre-test hook for PyTorch: increase max failing tests for ARM for PyTorch 2.1.2
See https://github.com/EESSI/software-layer/pull/444#issuecomment-1890416171
"""
if self.name == 'PyTorch' and self.version == '2.1.2' and get_cpu_architecture() == AARCH64:
self.cfg['max_failed_tests'] = 10


def pre_single_extension_hook(ext, *args, **kwargs):
"""Main pre-configure hook: trigger custom functions based on software name."""
if ext.name in PRE_SINGLE_EXTENSION_HOOKS:
Expand Down Expand Up @@ -527,6 +536,7 @@ def inject_gpu_property(ec):
'ESPResSo': pre_test_hook_ignore_failing_tests_ESPResSo,
'FFTW.MPI': pre_test_hook_ignore_failing_tests_FFTWMPI,
'SciPy-bundle': pre_test_hook_ignore_failing_tests_SciPybundle,
'PyTorch': pre_test_hook_increase_max_failed_tests_arm_PyTorch,
}

PRE_SINGLE_EXTENSION_HOOKS = {
Expand Down

0 comments on commit dc7d306

Please sign in to comment.