Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Fix various comment typos #11740

Closed
wants to merge 1 commit into from

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jan 18, 2025

Description

Found typos via codespell -q 3 -S "*.ini,./AUTHORS,./UI/data/locale,./deps/w32-pthreads" -L abitrate,aci,addres,caf,currentry,datas,dur,iff,inout,lod,mot,mut,numer,ot,parm,ques,settinga,statics,trun,uint,vas,writen

Motivation and Context

Improving accuracy of source comment for quality, readability, and may be used to generate source docs

How Has This Been Tested?

n/a

Types of changes

Documentation (a change to documentation pages)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Copy link
Member

@gxalpha gxalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert any changes in simde, that’s a dependency. Feel free to fix those issues upstream.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 18, 2025

@gxalpha any chance you can help me figure out where upstream is ? I did a search in the code and github and couldn't locate.

@gxalpha
Copy link
Member

gxalpha commented Jan 18, 2025

https://github.com/simd-everywhere/simde, but it looks like they're already fixed. simde has already been included in obs-deps and will at some point be used from there (and removed from this repo, see e.g.#10961), so there is nothing to fix in that regard.

@RytoEX
Copy link
Member

RytoEX commented Jan 18, 2025

Please note that #11166 covers these changes already.

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 18, 2025

@umlaeute
Copy link

i'm not sure what I should cherry pick. all three changes of your 672afcb seem to be already in my 453c3ac.
so what am I missing?

@luzpaz
Copy link
Contributor Author

luzpaz commented Jan 18, 2025

I'm on my phone and can't confirm. If you say so, then I'll close this PR.

@luzpaz luzpaz closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants