Skip to content

Commit

Permalink
Update for PHPSimple HTMLDomParser
Browse files Browse the repository at this point in the history
This fixes the compatibility issue with PHP 7.3 issue sunra/php-simple-html-dom-parser#64 and Quinn-Interactive#36
  • Loading branch information
obj63mc committed Jan 8, 2019
1 parent 818d2c2 commit ba88c56
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"silverstripe/cms": "^4.1",
"jonom/silverstripe-text-target-length": "^2",
"wilr/silverstripe-googlesitemaps": "^2.1",
"sunra/php-simple-html-dom-parser": "^1.5",
"kub-at/php-simple-html-dom-parser": "^1.7",
"axllent/silverstripe-trailing-slash": "^2.1"
},
"require-dev": {
Expand Down
2 changes: 1 addition & 1 deletion src/Analysis/Analysis.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Injector\Injectable;
use SilverStripe\View\ArrayData;
use Sunra\PhpSimple\HtmlDomParser;
use KubAT\PhpSimple\HtmlDomParser;
use Vulcan\Seo\Extensions\PageHealthExtension;

/**
Expand Down
6 changes: 3 additions & 3 deletions src/Extensions/PageHealthExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use SilverStripe\Forms\TextField;
use SilverStripe\Forms\ToggleCompositeField;
use SilverStripe\ORM\DataExtension;
use Sunra\PhpSimple\HtmlDomParser;
use KubAT\PhpSimple\HtmlDomParser;
use Vulcan\Seo\Analysis\Analysis;
use Vulcan\Seo\Forms\GoogleSearchPreview;
use Vulcan\Seo\Forms\HealthAnalysisField;
Expand Down Expand Up @@ -59,11 +59,11 @@ public function getRenderedHtml()
if (!$this->renderedHtml) {
$this->renderedHtml = file_get_contents($this->getOwner()->AbsoluteLink().'?stage=Stage');
}

if ($this->renderedHtml === false) {
$this->renderedHtml = '<p></p>';
}

return $this->renderedHtml;
}

Expand Down

0 comments on commit ba88c56

Please sign in to comment.