Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from macos-12 to macos-13 #1021

Closed
wants to merge 2 commits into from
Closed

Update from macos-12 to macos-13 #1021

wants to merge 2 commits into from

Conversation

VocalFan
Copy link
Member

@VocalFan VocalFan commented Oct 6, 2024

This is due to macos-12 soon being deprecated: actions/runner-images#10721

As such, I bumped our runners that are using macos-12 to macos-13. Not macos-14, as that is an ARM64 based runner as shown here:

macOS 13	macos-13 or macos-13-large	macOS-13
macOS 13 Arm64	macos-13-xlarge			macOS-13-arm64

As long as macos-13 is used and not macos-13-xlarge, we'll stay on the intel platform.

@VocalFan
Copy link
Member Author

VocalFan commented Oct 6, 2024

Not sure if this is really a ME thing but...

error[E0531]: cannot find unit struct, unit variant or constant `VMX_REASON_HLT` in crate `hv_sys`
  --> gui/src/vmm/hv/macos/x86_64.rs:26:24
   |
26 |             Ok(hv_sys::VMX_REASON_HLT) => Ok(()),
   |                        ^^^^^^^^^^^^^^ not found in `hv_sys`
error[E0425]: cannot find value `HV_DEADLINE_FOREVER` in crate `hv_sys`
   --> gui/src/vmm/hv/macos/cpu.rs:149:71
    |
149 |             unsafe { hv_sys::hv_vcpu_run_until(self.instance, hv_sys::HV_DEADLINE_FOREVER) },
    |                                                                       ^^^^^^^^^^^^^^^^^^^ not found in `hv_sys`
error[E0425]: cannot find value `VMCS_RO_EXIT_REASON` in crate `hv_sys`
   --> gui/src/vmm/hv/macos/cpu.rs:159:29
    |
159 |                     hv_sys::VMCS_RO_EXIT_REASON,
    |                             ^^^^^^^^^^^^^^^^^^^ not found in `hv_sys`
    ```

@ultimaweapon
Copy link
Member

Strange. AFAIK hv-sys embeded a generated binding instead of generate it from the computer it is running. Switching macOS version should not cause this error.

@VocalFan
Copy link
Member Author

VocalFan commented Oct 6, 2024

Yeah, and I'd rather our builds not get halted by "brownout" periods to make developers move to a newer version than macos-12

@ultimaweapon
Copy link
Member

@SuchAFuriousDeath do you want to maintain this? If not I think we should remove macOS x86 because no one want to maintenance it. It is going to die anyway since Apple already moved to ARM.

@ultimaweapon
Copy link
Member

Let's remove macOS x86.

@SuchAFuriousDeath
Copy link
Contributor

I agree.

Copy link

github-actions bot commented Nov 9, 2024

We are closing this PR due to no any activities in the last 30 days. Feel free to re-open it if you would like to continue working on this.

@github-actions github-actions bot closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants