Fix storage scanner parsing error

[tomasfratrik]

The given error arises when storage scanner actor attempts to parse output from command pvs while output containts separator symbol within itself. Changed the format of physical volume as was suggested in the ticket so it contains separator :, and was given following error while preupgrade and upgrade.
(e.g: format of physical volume, contains the symbol : `/dev/disk/by-path/pci-0000:00:03.0-part2)

  File "/etc/leapp/repos.d/system_upgrade/common/actors/storagescanner/libraries/storagescanner.py", line 195, in _get_pvs_info
    pv, vg, fmt, attr, psize, pfree = entry
ValueError: too many values to unpack (expected 6)

Therefore changing the separation symbol to |, and running preupgrade and upgrade from RHEL8 to RHEL9 didn't raise any errors.

Jira: RHEL-34570

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please @oamg/developers to notify leapp developers of the review request
• /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build.
However, here are additional useful commands for packit:

• /packit test to re-run manually the default tests
• /packit retest-failed to re-run failed tests manually
• /packit test oamg/leapp#42 to run tests with leapp builds for the leapp PR#42 (default is latest upstream - master - build)

Note that first time contributors cannot run tests automatically - they need to be started by a reviewer.

It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported, beaker-minimal and kernel-rt, both can be used to be run on all upgrade paths or just a couple of specific ones.
To launch on-demand tests with packit:

• /packit test --labels kernel-rt to schedule kernel-rt tests set for all upgrade paths
• /packit test --labels beaker-minimal-8.10to9.4,kernel-rt-8.10to9.4 to schedule kernel-rt and beaker-minimal test sets for 8.10->9.4 upgrade path

See other labels for particular jobs defined in the .packit.yaml file.

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

[pirat89]

@tomasfratrik rebase against master. tests should be fixed now

[matejmatuska]

/packit retest-failed

[tomasfratrik]

/packit retest-failed

[matejmatuska]

/packit retest-failed

[matejmatuska]

@tomasfratrik Works as expected now, please squash the commits and I can approve this.

[tomasfratrik]

The latest push squashes commits.

[MichalHe]

/packit retest-failed

[MichalHe]

/packit test

[MichalHe]

@tomasfratrik Hmm, if you step back and read the commit message with fresh eyes, it is not clear what does "this issue" refers to:

Output separators were before set to ':', but the output values (e.g.
from command 'pvs -a') could also contain this symbol,
therefore changing separator symbol fixes this issue.

Could you please rephrase the commit message describes the problem without ambiguous references?

Below, you can find my suggestion, but I feel that it is a bit too detailed, maybe there is a shorter one.

The storagescanner actor uses : as a separator when parsing the output of, e.g., pvs -a. However, this is problematic as, e.g., PCI paths in /dev/disk/by-path might contain : in their names. Since we split outputs of executed commands using this separator, having more : in the output than expected causes the actor to crash. This commit, therefore, changes the separator to |.

[tomasfratrik]

Yes you are right about the commit message. There are many ambiguous references. So I took your suggestion and made concise version. lmk if I should change it again.

[MichalHe]

I have retested the PR and it works as expected. LGTM!