Support Qt in namespace (#69) #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable support for Qt built with the -qtnamespace configure option Do it properly this time with QT_FORWARD_DECLARE_CLASS
|
No need to apologize, it was my fault for not checking more. I'll need to build a namespaced Qt version in order to properly check this PR, it might take some time with my nearly 10 years old PC at home, so I'll try to do that over the weekend :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a second try with QT_FORWARD_DECLARE_CLASS. Apologies again for the other PR, I'm using MSVC where the way I did it before 'works'.