Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing mismatched look up ids #2731

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fixing mismatched look up ids #2731

merged 1 commit into from
Oct 27, 2024

Conversation

svv232
Copy link
Member

@svv232 svv232 commented Oct 26, 2024

the lookup table id enum does not match the from_u32 function

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (3e42796) to head (ba2d00c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/lookups.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2731      +/-   ##
==========================================
+ Coverage   72.49%   72.50%   +0.01%     
==========================================
  Files         247      247              
  Lines       57716    57706      -10     
==========================================
- Hits        41843    41842       -1     
+ Misses      15873    15864       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@dannywillems dannywillems merged commit f0c3260 into master Oct 27, 2024
8 checks passed
@dannywillems dannywillems deleted the sai/fixing-lookuprs-bug branch October 27, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants