Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/pickles remove error #2730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcbeunardeau88
Copy link
Contributor

The error field in a proof was a leftover from folding.
We remove it when using pickles.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (fizzixnerd/marc/o1vm/verif@7201003). Learn more about missing BASE report.

Files with missing lines Patch % Lines
o1vm/src/pickles/column_env.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##             fizzixnerd/marc/o1vm/verif    #2730   +/-   ##
=============================================================
  Coverage                              ?   73.20%           
=============================================================
  Files                                 ?      248           
  Lines                                 ?    57994           
  Branches                              ?        0           
=============================================================
  Hits                                  ?    42457           
  Misses                                ?    15537           
  Partials                              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not from folding.

@marcbeunardeau88 marcbeunardeau88 changed the base branch from master to fizzixnerd/marc/o1vm/verif October 24, 2024 13:57
@marcbeunardeau88 marcbeunardeau88 force-pushed the fizzixnerd/marc/o1vm/verif branch 2 times, most recently from b6dbc5d to 940d2b2 Compare October 28, 2024 17:07
Base automatically changed from fizzixnerd/marc/o1vm/verif to master October 31, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants