Skip to content

Commit

Permalink
o1vm/pickles: Remove wrong comments and cleanup for CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Fizzixnerd committed Oct 30, 2024
1 parent 7201003 commit 0d8e46d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions o1vm/src/pickles/prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ where
error,
selector,
} = &polys;
// Note: We add a constant blinder in case we have a column with only zeroes.

let comm = |poly: &DensePolynomial<G::ScalarField>| {
srs.commit_custom(
poly,
Expand Down Expand Up @@ -383,9 +383,7 @@ where
.map(|poly| {
(
DensePolynomialOrEvaluations::DensePolynomial(poly),
// We do not have any blinder, therefore we set to 1,
// since otherwise we might commit to the zero polynomial
// and that would be bad!
// We do not have any blinder, therefore we set to 1.
PolyComm::new(vec![G::ScalarField::one()]),
)
})
Expand Down
2 changes: 1 addition & 1 deletion o1vm/src/pickles/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ fn test_small_circuit() {
verify::<Pallas, BaseSponge, ScalarSponge>(domain, &srs, &vec![expr.clone()], &proof);
let instant_after_verification = Instant::now();
debug!(
"Verification took: {}",
"Verification took: {} ms",
(instant_after_verification - instant_before_verification).as_millis()
);
assert!(verif, "Verification fails");
Expand Down
1 change: 0 additions & 1 deletion o1vm/src/pickles/verifier.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

use ark_ec::{AffineRepr, Group};
use ark_ff::{Field, One, PrimeField, Zero};
use itertools::Itertools;
use rand::thread_rng;

use kimchi::{
Expand Down

0 comments on commit 0d8e46d

Please sign in to comment.