Make panic recovery code consistent

utils/crons/cron.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"log/slog"
+	"runtime/debug"
 	"sync"
 	"time"
 
@@ -117,9 +118,10 @@ func fireCron(rt *runtime.Runtime, name string, cronFunc Function, timeout time.
 
 	defer func() {
 		// catch any panics and recover
-		panicLog := recover()
-		if panicLog != nil {
-			slog.Error(fmt.Sprintf("panic running cron: %s", panicLog), "cron", name)
+		if panicVal := recover(); panicVal != nil {
+			debug.PrintStack()
+
+			slog.Error("panic running cron", "cron", name, "panic", panicVal)
 		}
 	}()
 

web/middleware.go

@@ -38,9 +38,11 @@ func requestLogger(next http.Handler) http.Handler {
 func panicRecovery(next http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		defer func() {
-			if rvr := recover(); rvr != nil {
+			if panicVal := recover(); panicVal != nil {
 				debug.PrintStack()
-				slog.Error("recovered from panic in web handling", "error", fmt.Sprint(rvr))
+
+				slog.Error("panic in web handling", "url", r.URL.String(), "panic", panicVal)
+
 				http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
 			}
 		}()

workers.go

@@ -160,10 +160,10 @@ func (w *Worker) handleTask(task *queues.Task) {
 
 	defer func() {
 		// catch any panics and recover
-		panicLog := recover()
-		if panicLog != nil {
+		if panicVal := recover(); panicVal != nil {
 			debug.PrintStack()
-			log.Error("panic handling task", "panic", panicLog, "task", string(task.Task))
+
+			log.Error("panic handling task", "task", string(task.Task), "panic", panicVal)
 		}
 
 		// mark our task as complete