Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ipinfoLocal.mmdb file lookup #66

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

breakertt
Copy link

Both source code and documents are updated, however, I only tested on Linux environment.

@tsosunchia
Copy link
Member

Good job
但是为了统一环境变量的读取方式,
需要修改这部分代码

envIPInfoLocalPath := os.Getenv("NEXTTRACE_IPINFOLOCALPATH")

需要放在这个文件里https://github.com/nxtrace/NTrace-V1/blob/main/util/util.go
并参考该文件中19行附近的代码

非常感谢您的工作

@breakertt
Copy link
Author

Thanks a lot for your quick reply, I have made the refactor you requested.

@tsosunchia
Copy link
Member

Searching for ipinfoLocal.mmdb in these folders: [/root/ /root/ /usr/local/share/nexttrace/ /usr/share/nexttrace/]
目前的默认行为是显示这条日志,是不是不显示更好一些呢?

@breakertt
Copy link
Author

Sorry it is meant to be debug only, I should have removed it before committing.

@tsosunchia
Copy link
Member

根据 ACTIONS 的自动检查,ipgeo/ipinfoLocal.go 中需要修改

"fmt" imported and not used

@breakertt
Copy link
Author

Sorry fixed

@tsosunchia tsosunchia merged commit eea77b1 into nxtrace:main Aug 15, 2024
16 of 36 checks passed
@tsosunchia
Copy link
Member

well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants