Fix bug in bdDetect device registration affecting Albatross #17585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@burmancomp could you please confirm whether this fixes the issue? |
SaschaCowley
added
the
conceptApproved
seanbudd
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17537 (comment)
Summary of the issue:
In #17537, I introduced aa new addUsbDevice method on
DriverRegistrar, but it had parameter ordering wrong.Description of user facing changes
Albatross detection should work again.
Description of development approach
Fixed order. I added a bunch of unit tests to avoid this in the future.
Testing strategy:
Unit tests.
Known issues with pull request:
None known
Code Review Checklist:
@coderabbitai summary