Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code #17573

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code #17573

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
725b75d
Fix issue with certain SECTION elements not being recognized as edita…
cary-rowen Dec 30, 2024
9afb802
Update changes.
cary-rowen Dec 30, 2024
a318a4c
Move change entries to 2025.1
cary-rowen Jan 8, 2025
0b96b25
Update user_docs/en/changes.md
seanbudd Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions source/appModules/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ def chooseNVDAObjectOverlayClasses(self, obj, clsList):
clsList.insert(0, VSCodeDocument)

def event_NVDAObject_init(self, obj: NVDAObject):
# This is a specific fix for Visual Studio Code,
# However, the root cause of the issue is issue #15159.
# Once issue #15159 is fixed,
# The PR #16248 that introduced this code can be immediately reverted.
# (see issue #15159 for full description)
if obj.role != controlTypes.Role.EDITABLETEXT:
# TODO: This is a specific fix for Visual Studio Code.
# Once the underlying issue is resolved, this workaround can be removed.
# See issue #15159 for more details.
if obj.role != controlTypes.Role.EDITABLETEXT and controlTypes.State.EDITABLE not in obj.states:
obj.TextInfo = NVDAObjectTextInfo
3 changes: 2 additions & 1 deletion user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,12 +182,13 @@ Use `gui.message.MessageDialog` instead. (#17582)

## 2024.4.2

This is a patch release to fix bugs with braille devices and reading math in Chromium.
This is a patch release to fix bugs with braille devices and reading math in Chromium, as well as an issue with NVDA reading certain editable text fields in Visual Studio Code.

### Bug fixes

* Fixed bug with with reading math in Chromium Browsers (Chrome, Edge). (#17421, @NSoiffer)
* Humanware Brailliant BI 40X devices running firmware version 2.4 now work as expected. (#17518, @bramd)
* Fix issue with certain SECTION elements not being recognized as editable controls in Visual Studio Code. (#17573, @Cary-rowen)
cary-rowen marked this conversation as resolved.
Show resolved Hide resolved

## 2024.4.1

Expand Down