Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add more constraints to bdDetect USB device registration #17537

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Dec 16, 2024

Link to issue number:

Fixes #17521

Summary of the issue:

In several cases, registering a USB device in bdDetect with just VID and PID is not enough. We need an extra filter to ensure that only the right devices are detected. This was fixed at the driver level until now, but fixing this in bdDetect improves performance and stability.

Description of user facing changes

More stability and quicker detection times.

Description of development approach

Added the ability to register a match func that further constraints device detection for specific VID/PID combinations.

Testing strategy:

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 16, 2024
@seanbudd seanbudd added this to the 2025.1 milestone Dec 16, 2024
@burmancomp
Copy link
Contributor

You can also remove VID_AND_PID definition from albatross/constants.py because it is not used elsewhere.

@AppVeyorBot
Copy link

See test results for failed build of commit 2574273c55

@LeonarddeR LeonarddeR marked this pull request as ready for review December 26, 2024 10:16
@LeonarddeR LeonarddeR requested a review from a team as a code owner December 26, 2024 10:16
@LeonarddeR LeonarddeR requested a review from seanbudd December 26, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign bdDetect USB device registration
5 participants