-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update information for translating the interface with Crowdin #16718
Conversation
WalkthroughThe changes involved updating and adding documentation for translating NVDA's interface using Crowdin. This includes creating a new Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
Outside diff range and nitpick comments (4)
projectDocs/translating/readme.md (4)
Line range hint
3-3
: Correct the verb form for better grammatical accuracy.- Thank you for considering to localize NVDA to your language, or improving an existing translation. + Thank you for considering localizing NVDA to your language, or improving an existing translation.Tools
LanguageTool
[uncategorized] ~11-~11: The preposition ‘to’ seems more likely in this position. (AI_HYDRA_LEO_REPLACE_FOR_TO)
Context: ... is an English low traffic list devoted for the discussion of translation.
Import...
Line range hint
12-12
: Add hyphens to 'up-to-date' for grammatical correctness.- Important messages that relate to translators will also be sent here, e.g. before official NVDA releases, to remind translators to make sure their localization is up to date. + Important messages that relate to translators will also be sent here, e.g. before official NVDA releases, to remind translators to make sure their localization is up-to-date. - Translators should ensure their translation is up to date during the beta period before each new release, in order for it to be included in the upcoming final release. + Translators should ensure their translation is up-to-date during the beta period before each new release, in order for it to be included in the upcoming final release. - You can view [Crowdin](https://crowdin.com/project/nvda) for an up to date report on the status of translating the NVDA interface. + You can view [Crowdin](https://crowdin.com/project/nvda) for an up-to-date report on the status of translating the NVDA interface.Also applies to: 16-16, 23-23
Tools
LanguageTool
[uncategorized] ~11-~11: The preposition ‘to’ seems more likely in this position. (AI_HYDRA_LEO_REPLACE_FOR_TO)
Context: ... is an English low traffic list devoted for the discussion of translation.
Import...
Line range hint
19-19
: Add a comma after 'information' for better readability.- For further information please see the [Release Process page](https://github.com/nvaccess/nvda/blob/master/projectDocs/community/releaseProcess.md). + For further information, please see the [Release Process page](https://github.com/nvaccess/nvda/blob/master/projectDocs/community/releaseProcess.md).Tools
LanguageTool
[uncategorized] ~11-~11: The preposition ‘to’ seems more likely in this position. (AI_HYDRA_LEO_REPLACE_FOR_TO)
Context: ... is an English low traffic list devoted for the discussion of translation.
Import...
Line range hint
47-47
: Change 'send an email' to 'email' for conciseness.- You can send an email to the translation mailing list to find out the correct person. + You can email the translation mailing list to find out the correct person.Tools
LanguageTool
[uncategorized] ~11-~11: The preposition ‘to’ seems more likely in this position. (AI_HYDRA_LEO_REPLACE_FOR_TO)
Context: ... is an English low traffic list devoted for the discussion of translation.
Import...
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general comment:
There is no paragraph to describe the usage of the web interface; does it mean that NVDA recommends poedit? poedit does not allow to see the unapproved translation proposals of other people.
My feeling is that there are 2 use cases to translate the interface for a specific language:
- If there is only one translator of the interface for a specific language; in this case the usage of poedit is recommanded because it is easier. Note that to send a po file with approval; synchronization does not seem enough; you need to manually upload your file on Crowdin's web interface, checking the approval checkbox.
- If there are many translators for the interface; in this case, the web interface, although less comfortable, cannot be avoided
Co-authored-by: Cyrille Bougot <[email protected]>
@seanbudd thanks, you have taken into consideration my comments. However, I am quite concerned by the way this documentation is written. There seems to be actually 3 ways to translate:
And the documentation seems to mention parts of the process for one way or the other but does not make a clear distinction between these possible processes, i.e. steps from 2 distinctive processes seems a bit mixed together. The consequence is that a user will have difficulty to identify a step-by-step process to follow. Note however that I may not master all the possible processes, taking into account that I personally do not feel Crowdin very easy cand comfortable to use. That's why I had asked to other people on the translators mailing list to review this PR. Unfortunately no one has shown up. Maybe @ruifontes, @Adriani90, @zstanecic would you mind review this PR? |
@CyrilleB79 - I'll add a rough outline at the start of the documented covering an overview of these main workflow processes. I think this will help clarify the rest of the instructions |
@CyrilleB79 - I've added a new section |
…o addCrowdinDocs
@seanbudd I am unsure the document is complete, but I have no other feedback for now. I would have appreciated that other translators comment here but this has not been the case. If no other feedback is received, I'd recommend to merge as is and to update the document in another PR in case we get more feedback in the future. I'll try a last call on the translators mailiing list since the strings for 2024.3 have just been made available for translation. Also, have you tried yourself all what is written in the document? If not, it would be useful given the lack of received feedback. |
On the translators mailing list, someone offered to contribute with a tutorial for Crowdin-only usage. |
Co-authored-by: Cyrille Bougot <[email protected]>
@CyrilleB79 - thanks for the feedback. I've responded to the mailing list. And yes, to confirm, I've gone through all the processes with NVDA up to the point of committing any changes. |
Link to issue number:
Closes #16656
Summary of the issue:
NV Access is intending to move most of the wiki into the repository, so changes are tracked better and easier to propose.
The documentation for translating NVDA is very dated, particularly since the update of the translation system.
Description of user facing changes
This wiki page was moved and updated in the project docs
The following changes were made to update the contents:
Future work
This wiki pages will be removed/deprecated when this PR is merged.
Moving and updating the rest of the translating wiki pages.
Summary by CodeRabbit
Documentation
Chores