-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra warning to "Installing add-ons" section of User Guide #16510
Open
Qchristensen
wants to merge
16
commits into
master
Choose a base branch
from
Qchristensen-add-on-install-note
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1cfb8f8
Add extra warning to "Installing add-ons" section of User Guide
Qchristensen 6415643
Update user_docs/en/userGuide.md
Qchristensen 6139aa4
Update user_docs/en/userGuide.md
Qchristensen 60e68d4
Update user_docs/en/userGuide.md
Qchristensen 64856b1
Update user_docs/en/userGuide.md
Qchristensen 4278c19
Update user_docs/en/userGuide.md
Qchristensen 00752a3
Update user_docs/en/userGuide.md
Qchristensen 90105de
Update user_docs/en/userGuide.md
Qchristensen bfa14e6
Update user_docs/en/userGuide.md
Qchristensen 68b7bf2
Update user_docs/en/userGuide.md
Qchristensen e3d12ae
Update user_docs/en/userGuide.md
Qchristensen bb2121d
Update user_docs/en/userGuide.md
Qchristensen 9f9371f
Update user_docs/en/userGuide.md
Qchristensen ee3e04a
Update user_docs/en/userGuide.md
Qchristensen cf0d463
Update user_docs/en/userGuide.md
Qchristensen bd957a5
Update user_docs/en/userGuide.md
Qchristensen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you want to commit this somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to part of the previous paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially had it at the end of that paragraph, but just reading it again as a whole:
"Just because an add-on is available in the NVDA Add-on Store, does not mean that it has been approved or vetted by NV Access or anyone else. It is very important to only install add-ons from sources you trust. The functionality of add-ons is unrestricted inside NVDA. This could include accessing your personal data or even the entire system."
Perhaps between "... approved or vetted by NV Access or anyone else." and "It is very important to only install add-ons from sources you trust..." would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense to me