Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update triage docs: needs-triage, p3 crashes/freezes #16113

Merged
merged 1 commit into from
Feb 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions projectDocs/issues/triage.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,22 @@ We also have a label for `enhancement`, think of this as a more internal facing

### Triaged status
An issue is triaged if it is ready to be worked on.
Once a bug has clear steps to reproduce and is well documented, the `triaged` label can be applied.
New features and enhancements should be [well defined](#new-features-1) before applying the `triaged` label.
Once a bug has clear steps to reproduce and is well documented, the `triaged` label can be applied.
A `triaged` issue should also have a [priority label](#priority).
Generally these labels are provided by NV Access only, particularly for issues that are controversial, or priority is unclear.

For controversial changes, a product decision from NV Access may be required before applying the `triaged` label.
This can be indicated with adding the label `blocked/needs-product-decision`.

If it is a complex issue, technical investigation may be required. This can be indicated with adding the label `blocked/needs-technical-investigation`.
If an issue has been checked by NV Access, and needs further triage, the `needs-triage` label will be applied.
Please notify NV Access when you believe the issue is ready for the `triaged` label.

A `triaged` issue that requires a complex fix may require advice from NV Access, such as a project plan, before implementation is started.
An issue with a simple solution should get labelled `good first issue`.

For controversial changes, a product decision from NV Access may be required before applying the `triaged` label. This can be indicated with adding the label `blocked/needs-product-decision`.
An issue with a simple solution should get labelled `good first issue`.
If it is a complex issue, technical investigation may be required.
This can be indicated with adding the label `blocked/needs-technical-investigation`.

### Priority
Bugs/regressions are given priorities based on an estimate of their severity and impact.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning in L164 that P1s can also be a patch release? Are they considered milestones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worthwhile documenting this. Sometimes we create milestones for patch releases, particularly when there are multiple issues involved

Expand All @@ -167,6 +174,7 @@ Bugs/regressions are given priorities based on an estimate of their severity and
- Popular task not supported and no work around
- Misleading information or misleading handling from a popular task or feature
- `P3`:
- Crash, freeze, instability or performance issue that affects one user, i.e. it cannot be reproduced by anyone else.
- Feature does not work as expected
- Task not supported and no work around
- Misleading information or misleading handling
Expand Down