Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native selection in Microsoft Outlook: NVDA reports "native copy" #16202

Closed
Adriani90 opened this issue Feb 20, 2024 · 8 comments
Closed

native selection in Microsoft Outlook: NVDA reports "native copy" #16202

Adriani90 opened this issue Feb 20, 2024 · 8 comments
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. needs-triage
Milestone

Comments

@Adriani90
Copy link
Collaborator

Adriani90 commented Feb 20, 2024

Steps to reproduce:

  1. Open an email in MS Outlook
  2. Run NVDA and Switch to browse mode
  3. Select some text
  4. Press ctrl+c

Actual behavior:

NVDA reports the NVDA specific message "native copy".
Users get confused because they might get the impression that the copied content in browse mode is different than the one in focus mode. So this is a regression.

Expected behavior:

NVDA should report the "copy" message retrieved by the Outlook app module in browse mode, as it was before impelemnting native copy and same as it does in focus mode, because the same content is copied both in browse and focus mode.

NVDA logs, crash dumps and other attachments:

n/a

System configuration

NVDA installed/portable/running from source:

installed

NVDA version:

alpha-31113,6a43521f (2024.2.0.31113)

Windows version:

Windows 11 23 H2

Name and version of other software in use when reproducing the issue:

Microsoft 365 MSO (Version 2401 Build 16.0.17231.20236) 64 Bit

Other information about your system:

n/a

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

, 2024.1 Beta has the same issue.

If NVDA add-ons are disabled, is your problem still occurring?

yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

yes

@Adriani90
Copy link
Collaborator Author

cc: @michaelDCurran is it not possible to go the same way as for MS Excel? In MS Excel nothing changed when copying things in browse mode. Pressing nvda+shift+f10 in MS Excel just brings the context menu of a cell, while pressing ctrl+c both in browse and focus mode announces the same message.

@CyrilleB79
Copy link
Collaborator

Writing here for the current issue as for #16201.

Here is the situation with NVDA 2024.1beta9 when pressing control+C:

  • In Word with UIA:
    • BM (browse mode): "Native copy"
    • FM (focus mode): "Copy" (UIA notification)
  • In Word legacy:
    • BM: "Native copy" overspoken by "Copy" (UIA notification)
    • FM: "Copy" (UIA notification)
  • In Outlook (with UIA or legacy, no matter):
    • BM: "Native copy"
    • FM: Nothing

IMO, hearing "Native copy" is not a good user experience, even in Firefox. Indeed, an indication of the text that was copied (or the number of characters for long text) is a much more relevant information. In Office application, it is still less useful since the copy is always native in any case, as it has always been.

In 2023.3, the situation was as follows:

  • Outlook (with UIA or legacy):
    • BM: Copied in clipboard: text
    • FM: nothing
  • Word (with UIA or legacy):
    • BM: Copied to clipboard: text
    • FM: "Copy" (UIA notification)

This was much better.

@seanbudd seanbudd added this to the 2024.1 milestone Feb 26, 2024
@seanbudd seanbudd added blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. needs-triage labels Feb 27, 2024
@michaelDCurran
Copy link
Member

when pressing control+c in focus mode and or native selection, the reason we never say "copied to clipboard" and optionally the text, is because we cannot guarantee that the app actually copied something, and we cannot be sure what the text was that it copied. All we know is that we sent control+c to the app.
In browse mode we can do it as we are the one actually copying the text to the clipboard.
I have always (and probably always will) be unwilling to have NVDA announce that it copied text to the clipboard, unless we actually know it did.
this part can be debated further at some point, but,

For 2024.1 at least, we need to settle on which experience we want. It seems to me that the only option is:

  • pressing control+c in native selection mode should no longer say "native copy". Some people already seemed to not like this message, and it seems to conflict with / interrupt other native messages from the app. We would also remove the filtering from MS Word UIA notifications so that NVDA always announced MS Word's "copy" message all the time.
  • If however people do still want to hear "copyed to clipboard {text}" when pressing control+c in MS word browse mode, then we need to no longer treat this as equivalent to native selection mode, and go back to copying plain text ourselves. I don't think this would be great for NVDA 2024.1.

Therefore I propose:

  • Removing the "native copy" message all together and just letting the app do what ever it does.
  • Keep MS Word browse mode copy's new behaviour of copying rich text, but accept that MS Word will just say "copy" or what ever its UIA notification says. We will not say "copied to clipboard {text}". And I acknowledge that this is a deliberate change in behavior.

If this is okay, I shall open a new PR tomorrow. However, if we cannot come up with a consensus, I will simply leave it in its current state for 2024.1. and it should not block the release.

@CyrilleB79
Copy link
Collaborator

@michaelDCurran, I have not the time to double check today.
But it seems to me that the UX is worse after #16151 than before.

To summarize, if you cannot make something consistent and satisfying for Word browse mode before 2024.1, better try to stick to 2023.3 experience regarding Word browse mode.
And if NVDA+shift+F10 does not report the correct message in Word, we may fix this in 2024.2 more cleanly.

@Adriani90
Copy link
Collaborator Author

I have always (and probably always will) be unwilling to have NVDA announce that it copied text to the clipboard, unless we actually know it did.

I agree with this in general. In my view it suffices to hear "copy" in browse mode as well when pressing ctrl+c both in outlook and MS Word. This is what I hear when I copy something in focus mode. In MS Word. There is no difference between copying something in focus mode vs. browse mode so the message should be the same. Or am I wrong?
In MS Excel we hear "copy" both in focus and browse mode when pressing ctrl+c.

we cannot guarantee that the app actually copied something, and we cannot be sure what the text was that it copied. All we know is that we sent control+c to the app.

That's interesting to know, thanks for the info.
In this case a neutral but harmonized term like "copy" is best suited because it does not sugerate that something has been really copied but that's what ctrl+c stands for.

Narator reports this UIA message in focus mode and in its scan mode.

@michaelDCurran
Copy link
Member

Users get confused because they might get the impression that the copied content in browse mode is different than the one in focus mode. So this is a regression.

this is not a regression, rather it is a change in behavior. If you feel there is a contradiction with the user guide, please suggest a change to the documentation to make it clearer.

NVDA should report the "copy" message retrieved by the Outlook app module in browse mode, as it was before implementing native copy and same as it does in focus mode, because the same content is copied both in browse and focus mode.

I completely disagree. The change in behaviour is now that it copies like focus mode, thus it should not (nor can it) report the original message about copying in browse mode.

The behaviour will stay as is for 2024.1. But Feel free to suggest clarifications to documentation if necessary.
However, if there is in deed a regression or loss of behaviour (excluding a change in the message) then please state this more clearly.

@CyrilleB79
Copy link
Collaborator

@michaelDCurran, why have you closed this issue whereas #16262 is not merged?

seanbudd pushed a commit that referenced this issue Mar 6, 2024
…mode in browse mode (#16262)

Related to #16202 and #16201.

Summary of the issue:
In NVDA's new native selection mode in browse mode for Firefox, and MS word / Outlook browse mode, when native copying to clipboard with control+c, NVDA would report "native copy". this message has proven confusing and or unpopular. Thus this pr removes the message.
therefore, now when copying text with control+c when native seleciton mode is turned on, in Firefox / MS word / Outlook browse mode, NVDA will not say anything at all, and just let the application react the way it normally would (E.g. MS word may announce "copy" via its UIA notification).

Description of user facing changes
NVDA will no longer announce "native copy" when copying text with native selection mode.

Description of development approach
the "native copy" message has been removed from the clipyToclipboard script in cursorManager.
MS word's own "copy" UIA notification message is no longer suppressed in browse mode.
@CyrilleB79
Copy link
Collaborator

NVDA should report the "copy" message retrieved by the Outlook app module in browse mode, as it was before implementing native copy and same as it does in focus mode, because the same content is copied both in browse and focus mode.

I completely disagree. The change in behaviour is now that it copies like focus mode, thus it should not (nor can it) report the original message about copying in browse mode.

@michaelDCurran that's true for UIA but not for legacy. In 2023.3, in legacy browse mode, NVDA copied the text with its formatting and reported the text being copied. In 2024.1beta12 in legacy browse mode, NVDA copies the formatted text but does not report anything.
Could you clarify if NVDA reported the copied text not knowing if it had actually been copied by the application, or if NVDA was able to know that the copy actually had taken place even in browse mode? If the latter, I'll open an issue for this loss of information.

Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
…mode in browse mode (nvaccess#16262)

Related to nvaccess#16202 and nvaccess#16201.

Summary of the issue:
In NVDA's new native selection mode in browse mode for Firefox, and MS word / Outlook browse mode, when native copying to clipboard with control+c, NVDA would report "native copy". this message has proven confusing and or unpopular. Thus this pr removes the message.
therefore, now when copying text with control+c when native seleciton mode is turned on, in Firefox / MS word / Outlook browse mode, NVDA will not say anything at all, and just let the application react the way it normally would (E.g. MS word may announce "copy" via its UIA notification).

Description of user facing changes
NVDA will no longer announce "native copy" when copying text with native selection mode.

Description of development approach
the "native copy" message has been removed from the clipyToclipboard script in cursorManager.
MS word's own "copy" UIA notification message is no longer suppressed in browse mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/needs-product-decision A product decision needs to be made. Decisions about NVDA UX or supported use-cases. needs-triage
Projects
None yet
Development

No branches or pull requests

4 participants