-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
native selection in Microsoft Outlook: NVDA reports "native copy" #16202
Comments
cc: @michaelDCurran is it not possible to go the same way as for MS Excel? In MS Excel nothing changed when copying things in browse mode. Pressing nvda+shift+f10 in MS Excel just brings the context menu of a cell, while pressing ctrl+c both in browse and focus mode announces the same message. |
Writing here for the current issue as for #16201. Here is the situation with NVDA 2024.1beta9 when pressing control+C:
IMO, hearing "Native copy" is not a good user experience, even in Firefox. Indeed, an indication of the text that was copied (or the number of characters for long text) is a much more relevant information. In Office application, it is still less useful since the copy is always native in any case, as it has always been. In 2023.3, the situation was as follows:
This was much better. |
when pressing control+c in focus mode and or native selection, the reason we never say "copied to clipboard" and optionally the text, is because we cannot guarantee that the app actually copied something, and we cannot be sure what the text was that it copied. All we know is that we sent control+c to the app. For 2024.1 at least, we need to settle on which experience we want. It seems to me that the only option is:
Therefore I propose:
If this is okay, I shall open a new PR tomorrow. However, if we cannot come up with a consensus, I will simply leave it in its current state for 2024.1. and it should not block the release. |
@michaelDCurran, I have not the time to double check today. To summarize, if you cannot make something consistent and satisfying for Word browse mode before 2024.1, better try to stick to 2023.3 experience regarding Word browse mode. |
I agree with this in general. In my view it suffices to hear "copy" in browse mode as well when pressing ctrl+c both in outlook and MS Word. This is what I hear when I copy something in focus mode. In MS Word. There is no difference between copying something in focus mode vs. browse mode so the message should be the same. Or am I wrong?
That's interesting to know, thanks for the info. Narator reports this UIA message in focus mode and in its scan mode. |
this is not a regression, rather it is a change in behavior. If you feel there is a contradiction with the user guide, please suggest a change to the documentation to make it clearer.
I completely disagree. The change in behaviour is now that it copies like focus mode, thus it should not (nor can it) report the original message about copying in browse mode. The behaviour will stay as is for 2024.1. But Feel free to suggest clarifications to documentation if necessary. |
@michaelDCurran, why have you closed this issue whereas #16262 is not merged? |
…mode in browse mode (#16262) Related to #16202 and #16201. Summary of the issue: In NVDA's new native selection mode in browse mode for Firefox, and MS word / Outlook browse mode, when native copying to clipboard with control+c, NVDA would report "native copy". this message has proven confusing and or unpopular. Thus this pr removes the message. therefore, now when copying text with control+c when native seleciton mode is turned on, in Firefox / MS word / Outlook browse mode, NVDA will not say anything at all, and just let the application react the way it normally would (E.g. MS word may announce "copy" via its UIA notification). Description of user facing changes NVDA will no longer announce "native copy" when copying text with native selection mode. Description of development approach the "native copy" message has been removed from the clipyToclipboard script in cursorManager. MS word's own "copy" UIA notification message is no longer suppressed in browse mode.
@michaelDCurran that's true for UIA but not for legacy. In 2023.3, in legacy browse mode, NVDA copied the text with its formatting and reported the text being copied. In 2024.1beta12 in legacy browse mode, NVDA copies the formatted text but does not report anything. |
…mode in browse mode (nvaccess#16262) Related to nvaccess#16202 and nvaccess#16201. Summary of the issue: In NVDA's new native selection mode in browse mode for Firefox, and MS word / Outlook browse mode, when native copying to clipboard with control+c, NVDA would report "native copy". this message has proven confusing and or unpopular. Thus this pr removes the message. therefore, now when copying text with control+c when native seleciton mode is turned on, in Firefox / MS word / Outlook browse mode, NVDA will not say anything at all, and just let the application react the way it normally would (E.g. MS word may announce "copy" via its UIA notification). Description of user facing changes NVDA will no longer announce "native copy" when copying text with native selection mode. Description of development approach the "native copy" message has been removed from the clipyToclipboard script in cursorManager. MS word's own "copy" UIA notification message is no longer suppressed in browse mode.
Steps to reproduce:
Actual behavior:
NVDA reports the NVDA specific message "native copy".
Users get confused because they might get the impression that the copied content in browse mode is different than the one in focus mode. So this is a regression.
Expected behavior:
NVDA should report the "copy" message retrieved by the Outlook app module in browse mode, as it was before impelemnting native copy and same as it does in focus mode, because the same content is copied both in browse and focus mode.
NVDA logs, crash dumps and other attachments:
n/a
System configuration
NVDA installed/portable/running from source:
installed
NVDA version:
alpha-31113,6a43521f (2024.2.0.31113)
Windows version:
Windows 11 23 H2
Name and version of other software in use when reproducing the issue:
Microsoft 365 MSO (Version 2401 Build 16.0.17231.20236) 64 Bit
Other information about your system:
n/a
Other questions
Does the issue still occur after restarting your computer?
yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
, 2024.1 Beta has the same issue.
If NVDA add-ons are disabled, is your problem still occurring?
yes
Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
yes
The text was updated successfully, but these errors were encountered: