Skip to content

Commit

Permalink
No longer report "native copy" when copying text in native selection …
Browse files Browse the repository at this point in the history
…mode in browse mode (nvaccess#16262)

Related to nvaccess#16202 and nvaccess#16201.

Summary of the issue:
In NVDA's new native selection mode in browse mode for Firefox, and MS word / Outlook browse mode, when native copying to clipboard with control+c, NVDA would report "native copy". this message has proven confusing and or unpopular. Thus this pr removes the message.
therefore, now when copying text with control+c when native seleciton mode is turned on, in Firefox / MS word / Outlook browse mode, NVDA will not say anything at all, and just let the application react the way it normally would (E.g. MS word may announce "copy" via its UIA notification).

Description of user facing changes
NVDA will no longer announce "native copy" when copying text with native selection mode.

Description of development approach
the "native copy" message has been removed from the clipyToclipboard script in cursorManager.
MS word's own "copy" UIA notification message is no longer suppressed in browse mode.
  • Loading branch information
michaelDCurran authored and Adriani90 committed Mar 13, 2024
1 parent 0133ffb commit 207d6c8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
6 changes: 0 additions & 6 deletions source/NVDAObjects/UIA/wordDocument.py
Original file line number Diff line number Diff line change
Expand Up @@ -554,12 +554,6 @@ def event_UIA_notification(self, activityId=None, **kwargs):
# such as "delete back word" when Control+Backspace is pressed.
if activityId == "AccSN2": # Delete activity ID
return
# copy to clipboard
if activityId == 'AccSN3':
ti = self.treeInterceptor
if ti and not ti.passThrough:
# Browse mode provides its own copy to clipboard message.
return
super(WordDocument, self).event_UIA_notification(**kwargs)

# The following overide of the EditableText._caretMoveBySentenceHelper private method
Expand Down
2 changes: 0 additions & 2 deletions source/cursorManager.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,6 @@ def script_selectAll(self,gesture):

def script_copyToClipboard(self, gesture: inputCore.InputGesture):
if self._nativeAppSelectionMode:
# Translators: Reported when browse mode passes the copy to clipboard command through to the application.
ui.message(_("native copy"))
gesture.send()
return
info=self.makeTextInfo(textInfos.POSITION_SELECTION)
Expand Down
6 changes: 4 additions & 2 deletions user_docs/en/changes.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@ Windows 8.1 is the minimum Windows version supported.
- Added support for Bluetooth Low Energy HID Braille displays. (#15470)
- A new Native Selection mode (toggled by ``NVDA+shift+f10``) is now available in NVDA's browse mode for Mozilla Firefox.
When turned on, selecting text in browse mode will also manipulate Firefox's own native selection.
Copying text with ``control+c`` will pass straight through to Firefox, thus copying the rich content, rather than NVDA's plain text representation. (#15830)
- When copying text in Microsoft Word with NVDA's browse mode enabled, formatting is now also included. (#16129)
Copying text with ``control+c`` will pass straight through to Firefox, thus copying the rich content, rather than NVDA's plain text representation.
Note however that as Firefox is handling the actual copy, NVDA will not report a "copy to clipboard" message in this mode. (#15830)
- When copying text in Microsoft Word with NVDA's browse mode enabled, formatting is now also included.
A side affect of this is that NVDA will no longer report a "copy to clipboard" message when pressing ``control+c`` in Microsoft Word / Outlook browse mode, as the application is now handling the copy, not NVDA. (#16129)
- A new "on-demand" speech mode has been added.
When speech is on-demand, NVDA does not speak automatically (e.g. when moving the cursor) but still speaks when calling commands whose goal is explicitly to report something (e.g. report window title). (#481, @CyrilleB79)
- In the Speech category of NVDA's settings, it is now possible to exclude unwanted speech modes from the Cycle speech modes command (``NVDA+s``). (#15806, @lukaszgo1)
Expand Down

0 comments on commit 207d6c8

Please sign in to comment.