Skip to content

Commit

Permalink
Fix regression: make BASE_ONLY_SECTIONS no longer a frozen set (#16685)
Browse files Browse the repository at this point in the history
Fixes #16684

Summary of the issue:
In #16636 / d7facd1, config.ConfigManager.BASE_ONLY_SECTIONS underwent a mutation from a set to a frozenset.
Thhis modification hinders extensions from easily expanding this set.

There are perfectly legit scenarios where an extension’s settings should not be overridden by profiles. Take webAccess, for instance: accessolutions/WebAccessForNVDA@4251aae/addon/globalPlugins/webAccess/config.py
  • Loading branch information
seanbudd authored Jun 17, 2024
1 parent 798e750 commit 9829b3b
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions source/config/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -504,15 +504,18 @@ class ConfigManager(object):
Changed settings are written to the most recently activated profile.
"""

#: Sections that only apply to the base configuration;
#: i.e. they cannot be overridden in profiles.
BASE_ONLY_SECTIONS = frozenset({
BASE_ONLY_SECTIONS = {
"general",
"update",
"upgrade",
"development",
"addonStore",
})
}
"""
Sections that only apply to the base configuration;
i.e. they cannot be overridden in profiles.
Note this set may be extended by add-ons.
"""

def __init__(self):
self.spec = confspec
Expand Down

0 comments on commit 9829b3b

Please sign in to comment.