Skip to content

Commit

Permalink
[Hims] fix incorrectly assigned combination keys in braillesense devi…
Browse files Browse the repository at this point in the history
…ce (#16118)

Fixes #15306

Summary of the issue:
With a Hims BrailleSense 6, in terminal mode, four braille combinations cannot be performed on the braille keyboard.

Description of user facing changes
Some characters in french can type alt+arrow combination keys in braillesense.

Description of development approach
alt+arrow combination keys in hims driver which were assigned to Braillesense device was changed.
  • Loading branch information
EdKweon authored Feb 2, 2024
1 parent 916b3c9 commit 6d97c5a
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
8 changes: 4 additions & 4 deletions source/brailleDisplayDrivers/hims.py
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ def terminate(self):
"br(hims):dot2+dot7+f1",
),
"kb:alt+leftArrow": (
"br(hims):dot2+dot7",
"br(hims):dot2+dot7+space",
),
"kb:rightArrow": (
"br(hims):dot6+space",
Expand All @@ -612,7 +612,7 @@ def terminate(self):
"br(hims):dot5+dot7+f1",
),
"kb:alt+rightArrow": (
"br(hims):dot5+dot7",
"br(hims):dot5+dot7+space",
),
"kb:pageUp": (
"br(hims):dot1+dot2+dot6+space",
Expand All @@ -634,7 +634,7 @@ def terminate(self):
"br(hims):dot2+dot3+dot7+f1",
),
"kb:alt+upArrow": (
"br(hims):dot2+dot3+dot7",
"br(hims):dot2+dot3+dot7+space",
),
"kb:shift+upArrow": (
"br(hims):leftSideScrollDown+space",
Expand All @@ -659,7 +659,7 @@ def terminate(self):
"br(hims):dot5+dot6+dot7+f1",
),
"kb:alt+downArrow": (
"br(hims):dot5+dot6+dot7",
"br(hims):dot5+dot6+dot7+space",
),
"kb:shift+downArrow": (
"br(hims):space+rightSideScrollDown",
Expand Down
6 changes: 6 additions & 0 deletions user_docs/en/changes.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ What's New in NVDA
- When pressing ``ctrl+tab``, focus properly moves to the new current tab title. (#14986, @ABuffEr)
-
- In Adobe Reader, NVDA no longer ignores alternative text set on formulas in PDFs. (#12715)
- Changed several gestures for BrailleSense devices to avoid conflicts with characters of the French braille table. (#15306)
- ``alt+leftArrow`` is now mapped to ``dot2+dot7+space``
- ``alt+rightArrow`` is now mapped to ``dot5+dot7+space``
- ``alt+upArrow`` is now mapped to ``dot2+dot3+dot7+space``
- ``alt+downArrow`` is now mapped to ``dot5+dot6+dot7+space``
-
-


Expand Down
8 changes: 4 additions & 4 deletions user_docs/en/userGuide.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -3487,27 +3487,27 @@ Please see the display's documentation for descriptions of where these keys can
| control+shift+leftArrow key | dot2+dot8+space+f1 |
| control+leftArrow key | dot2+space |
| shift+alt+leftArrow key | dot2+dot7+f1 |
| alt+leftArrow key | dot2+dot7 |
| ``alt+leftArrow`` | ``dot2+dot7+space`` |
| rightArrow key | dot6+space, leftSideRightArrow |
| control+shift+rightArrow key | dot5+dot8+space+f1 |
| control+rightArrow key | dot5+space |
| shift+alt+rightArrow key | dot5+dot7+f1 |
| alt+rightArrow key | dot5+dot7 |
| ``alt+rightArrow`` | ``dot5+dot7+space`` |
| pageUp key | dot1+dot2+dot6+space |
| control+pageUp key | dot1+dot2+dot6+dot8+space |
| upArrow key | dot1+space, leftSideUpArrow |
| control+shift+upArrow key | dot2+dot3+dot8+space+f1 |
| control+upArrow key | dot2+dot3+space |
| shift+alt+upArrow key | dot2+dot3+dot7+f1 |
| alt+upArrow key | dot2+dot3+dot7 |
| ``alt+upArrow`` | ``dot2+dot3+dot7+space`` |
| shift+upArrow key | leftSideScrollDown+space |
| pageDown key | dot3+dot4+dot5+space |
| control+pageDown key | dot3+dot4+dot5+dot8+space |
| downArrow key | dot4+space, leftSideDownArrow |
| control+shift+downArrow key | dot5+dot6+dot8+space+f1 |
| control+downArrow key | dot5+dot6+space |
| shift+alt+downArrow key | dot5+dot6+dot7+f1 |
| alt+downArrow key | dot5+dot6+dot7 |
| ``alt+downArrow`` | ``dot5+dot6+dot7+space`` |
| shift+downArrow key | space+rightSideScrollDown |
| escape key | dot1+dot5+space, f4, brailleedge:f1 |
| delete key | dot1+dot3+dot5+space, dot1+dot4+dot5+space |
Expand Down

0 comments on commit 6d97c5a

Please sign in to comment.