Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle bad summary for add-ons #35

Merged
merged 1 commit into from
Feb 9, 2024
Merged

handle bad summary for add-ons #35

merged 1 commit into from
Feb 9, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Feb 9, 2024

An add-on submission failed due the manifest not containing expected keys.

Instead an error message should be posted

gerald-hartig
gerald-hartig approved these changes Feb 9, 2024
View reviewed changes
Copy link

@gerald-hartig gerald-hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under the assumption that all the fields are intended to be mandatory. Otherwise I'd suggest using something like this instead of the try/except:

manifest.get('summary', None))

@seanbudd seanbudd merged commit bb3aaa7 into main Feb 9, 2024
1 check passed
@seanbudd seanbudd deleted the handleBadFields branch February 9, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerald-hartig gerald-hartig gerald-hartig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanbudd @gerald-hartig