fix(core): fix missing query parameters when router.base is a subdirectory. #1827
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I have fixed a problem with query parameters being lost even with
fullPathRedirect
enabled.The problem occurs when a subdirectory is specified in
router.base
innuxt.config.js
as follows.This problem is caused by
normalizePath
being executed on the URL retrieved bythis.$storage.getUniversal('redirect')
.To avoid this problem, I have changed where
normalizePath
is executed.For example, if you intended to forward to
https://localhost/app/foo?bar=123
after login/foo?bar=123
will be replaced bynormalizePath
, resulting in a transfer tohttps://localhost/app/foo
.This problem has been resolved in this commit.
Issue is here #1828
Thanks for the confirmation.