Fix #652: option window doesnt work #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjeffer
changed the title
zjeffer
force-pushed
the
fix/zjeffer/qt-6.6-OptionItemButton-enabled
branch
from
f4f9bce to
95734b7
Compare
|
Appimage 5.15.2 works |
|
Appimage 6.4.3 also works |
guihkx
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Works for me too! But we should probably wait for @nuttyartist's review.
|
Works just fine (: Thanks, @zjeffer. |
nuttyartist
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that
enabledis a built-in QML property, and we were overwriting it. It seems that since 6.6, this overwriting actually causes an error, as opposed to previous versions.Fixed by not redefining the
enabledproperty, but simply setting totruein the constructor.Thanks to @dmytrovoytko for pointing us closer to the solution!
Tested and works on Qt 6.6.1