[Accessibility] Conform Doze Back Button height to apple guideline #54
Conversation
|
@jamie-brannan Thanks. I will run this PR change first through the Here are some observations for how to you could make Accessibility contributions which align with (and would have minimal impact on) the current the Daily Dozen development process. Some context... First, until relatively recently the iOS app could only support English. It also had a rigid layout. The layouts were reworked to allow for varied text lengths as required for multi-language inclusion. Anything which affects the visual layout would first go through the multi-language branch for visual testing. Multiple language testing is part of the visual layout stress testing. The daily-dozen-localization repository has a list of the languages which are in-process to be released. Second, Apple is transitioning away from Storyboards towards SwiftUI. The iOS Daily Dozen has been evolving to be able to migrate to SwiftUI. A significant part of this migration is how text strings (including accessibility strings) are handled. The workflows for visual and audio accessibility type updates are somewhat different. Visual Accessibility Visual Accessibility can be submitted on a specific per view basis. (... like you did here.) Starting the title with These visual submission could be either a PR against the Audio Accessibility Audio Accessibility is more of a potential mini-project which might be a good non-blocking, independent task. Both Apple VoiceOver and Android screen readers (such as TalkBack) use voice synthesis from text labels which describe UI elements. An Audio Accessibility text phrases set could be used by Apple Storyboards, Apple SwiftUI and Android platforms. Although, the first pass would be for English/iOS/Storyboards, the phrases need to be in a form which can be consumed by other platforms. And, the phrases would also need to be approachable for translators, if/when NutritionFacts might pursue such translations in the future. As such, an audio accessibility effort needs to include a TSV spreadsheet of spoken phrases associated with UI element ids and an explanations that could be used across the platforms. See Languages/English_US/tsv for how the Daily Dozen app currently coordinates texts between the iPhone app, the Android app and language translators. Caveat: I'm just commenting here on the current process from a development perspective; and not whether this project should or should-not be pursued at this time. If you remain interested after considering the process observations above, you may wish to create a specific Proposal/Discussion Issue topic with your ideas/scope in the |
|
Wow! Thank you @marc-medley so much for your welcoming my PR and insight to the projects trajectory. I'm taking note of points you've cited here and I'll initiate a proposal / discussion issue topic with my ideas in the repo |
Hello @marc-medley,
My name is Jamie and I'm an user of Daily Dozen and iOS Developper that's passionate about Accessibility.
Here are a few storyboard line changes – I noticed the
DozeBackButton's width was truncated within it's parent view and it's height was a few points short of the 44pt minimum recommended by the Apple Guidelines.I work on a public service app in my day job, and have a few ideas for the Voice Over user journey and more. I'd would love to contribute over the summer more if the project team is at all interested. 🙌
Cheers 🚀