[Dominic Siew Zhen Yu] iP #494

Domszy · 2021-08-28T15:24:11Z

DukeMan

"You will meet many defeats in life, but never let yourself be defeated!" (source: Top 100 most famous quotes)

Manage your tasks with DukeMan, an all-in-one task management application. 🙂

Categorise your tasks as deadlines, todo or events
~~FAST~~ SUPER FAST and easy to use
Great user interface

All you need to do to use DukeMan 👀

Download DukeMan.
Run the program on an IDE.
Use the todo, deadline and event commands to insert tasks into DukeMan.
Use the "remove" command to remove tasks, and the "done" command to mark the task as complete.
Use "list" to have a look at your tasks.
Use "bye" command to quite DukeMan.

DOWNLOAD NOW!

Download DukeMan to enhance your efficiency!
What are you waiting for?

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

nataniayp

overall it's fine! just a bit of naming conventions but otherwise looks good 👍

nataniayp · 2021-09-01T15:19:41Z

src/main/java/duke/Deadlines.java

+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+
+public class Deadlines extends Task{


You might want to change the class name to Deadline instead since plural forms are usually for a collection of data such as an array of deadlines. 😄

nataniayp · 2021-09-01T15:21:27Z

src/main/java/duke/DukeMan.java

+            String command = parser.getCommand();
+
+            switch(command) {
+                case "todo":


the indentation for case should be the same as switch

nataniayp · 2021-09-01T15:23:36Z

src/main/java/duke/Event.java

+     *
+     * @return a string representation of a Event object
+     */
+    public String printName() {


instead of printName, you might want to override the toString method instead since your method technically does not print the name

nataniayp · 2021-09-01T15:26:16Z

src/main/java/duke/taskList.java

+import java.io.*;
+import java.util.ArrayList;
+
+public class taskList {


class name should've been capitalised instead -- so TaskList instead of taskList ?

Javiier-pzk

Hi Dominic! Your code looks good overall but there are just a few naming and coding style issues that you should fix. Cheers!

Javiier-pzk · 2021-09-02T12:22:37Z

src/main/java/duke/DukeMan.java

+                    String todoName = parser.getTaskName();
+                    tasks.addTodo(todoName, true);
+                    break;
+                case "deadline":


case statement should have the same indentation level as switch

Javiier-pzk · 2021-09-02T12:26:46Z

src/main/java/duke/Parser.java

+     * @param input the given input by the user
+     */
+
+    public void parsing(String input) {


Perhaps a better name for this method will be parse? I think we generally should avoid adding '-ing' behind our methods and class names.

Javiier-pzk · 2021-09-02T12:30:39Z

src/main/java/duke/DukeMan.java

+ * @author Dominic Siew Zhen Yu
+ */
+
+public class DukeMan {


Perhaps you can name your class name in a way that explains what this class is supposed to do, as per the naming guidelines

Javiier-pzk · 2021-09-02T12:31:57Z

src/main/java/duke/Deadlines.java

+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+
+public class Deadlines extends Task{


You may want to change your class name to singular form (deadline) as plural forms are usually for collection of items.

Javiier-pzk · 2021-09-02T12:33:43Z

src/main/java/duke/taskList.java

+import java.io.*;
+import java.util.ArrayList;
+
+public class taskList {


As part of convention, your class name should have been capitalised. It should be TaskList instead of taskList

Javiier-pzk · 2021-09-02T12:34:22Z

src/main/java/duke/taskList.java

+                boolean isCompleted = (seperate2[0].equals("[✓]"))? true: false;
+                String eventInfo = seperate2[1];
+
+                switch(taskTypeText) {


Same indentation problem with switch and case

Javiier-pzk · 2021-09-02T12:35:56Z

src/main/java/duke/taskList.java

+
+            while ((currentLine = reader.readLine()) != null) {
+                String[] seperate1 = currentLine.toString().split(" ", 2);
+                String taskTypeText = seperate1[0];


Perhaps a better name would be taskString ?

Javiier-pzk · 2021-09-02T12:37:37Z

src/main/java/duke/Duke.java

+//
+///**
+// * Duke is a chatbot that takes in tasks, which includes todos, deadlines and events, and compiles them
+// * in a list. Tasks can be removed from the list and be marked as completed.


Just a friendly reminder that there should not be large chunks of commented code present as mentioned in the iP grading rubrics. You should delete them if not needed or transfer them somewhere else 😄

…ustToCheck

* commit 'd6bdc6f3d02334bc5b96ca48ec75a10c78365ca3': Update README.md Update README.md Set theme jekyll-theme-cayman Update README.md Update README.md Update README.md Update README.md Update README.md Update README.md Update README.md # Conflicts: # docs/README.md

damithc and others added 25 commits July 29, 2021 20:30

Add Gradle support

d839859

Update from AY2021 Semester 1 repository

b6778da

Level-1

7220928

merged with the previous repository

1a2d95d

Level-2

303818b

Level-3

acbcb55

Level-4

abea903

Level-5

3bf4e35

A-TextUiTesting

9c72b43

Level-6

83b6903

Level-7

b898992

Level-8

f262b2a

Merge branch 'branch-Level-7' into branch-Level-8

cf61fa5

A-MoreOOP

a5339e7

A-Packages

9e9677b

A-JUnit

7de2a27

A-Jar

c104acb

A-JavaDoc

9d956ee

A-CodingStandard

c3b8a36

Level-9

9e6a0bb

Merge branch 'branch-A-CodingStandard' into branch-Level-9

bc82e94

Merge branch 'branch-A-JavaDoc' into branch-Level-9

a624613

Update to the "find" function in DukeMan

5ecd6b0

A-Gradle

267983b

A-CheckStyle

5a47165

nataniayp reviewed Sep 1, 2021

View reviewed changes

Javiier-pzk reviewed Sep 2, 2021

View reviewed changes

Domszy added 3 commits September 3, 2021 22:22

Level-10

e8fbee9

no message

6366c20

Merge branch 'branch-A-Gradle' into branch-Level-10

705631c

Domszy and others added 30 commits September 16, 2021 21:25

Delete Ui.png

108b089

Add files via upload

e4b3604

Delete Ui.png

5e030db

Add files via upload

72128c9

Delete Ui.png

ced4cf1

Add files via upload

fa77e2d

Delete Ui.png

c53bb3f

Add files via upload

6981a3b

A-UserGuide

0ea394e

Merge commit '6981a3bb8c9bd3715f8ac8ba5bba0aec47a9fdea' into branch-J…

d25b45c

…ustToCheck

A-UserGuide

29443d1

Update README.md

11266e4

Add files via upload

1d270ac

Set theme jekyll-theme-slate

6844048

Fixed issues when pushing to repository

3e03fed

test tp user guide in iP

aabebbc

test tP's user guide

f5e9be1

Update README.md

b12cd04

Update README.md

ecf1a5e

Update README.md

a3a165f

Update README.md

2c6d297

Update README.md

08adcec

Update README.md

15978c9

Update README.md

cefaf54

Set theme jekyll-theme-cayman

d09d636

Update README.md

8bd56a8

Update README.md

d6bdc6f

no message

f79eefd

Update README.md

7a0dcb2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dominic Siew Zhen Yu] iP #494

[Dominic Siew Zhen Yu] iP #494

Domszy commented Aug 28, 2021 •

edited

Loading

nataniayp left a comment

nataniayp Sep 1, 2021

nataniayp Sep 1, 2021

nataniayp Sep 1, 2021

nataniayp Sep 1, 2021

Javiier-pzk left a comment

Javiier-pzk Sep 2, 2021

Javiier-pzk Sep 2, 2021

Javiier-pzk Sep 2, 2021

Javiier-pzk Sep 2, 2021

Javiier-pzk Sep 2, 2021

Javiier-pzk Sep 2, 2021

Javiier-pzk Sep 2, 2021

Javiier-pzk Sep 2, 2021

[Dominic Siew Zhen Yu] iP #494

Are you sure you want to change the base?

[Dominic Siew Zhen Yu] iP #494

Conversation

Domszy commented Aug 28, 2021 • edited Loading

DukeMan

nataniayp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Javiier-pzk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Domszy commented Aug 28, 2021 •

edited

Loading