[Shui Jie] ip #493

sj1999-BIT · 2021-08-28T14:32:51Z

Ultimate Normal Scheduler

I am not more gifted than anybody else. I am just more curious than the average person and I will not give up a problem until I have found the proper solution.
-Albert Einstein

The Ultimate Normal Scheduler has one aim and one aim only, to make support you to be the ultimate Task Master!

text-based cause the GUI has not been done yet.

download it from here.
double click it.
add your tasks, remove them, whatever you want!
let it remember your tasks for you. That's all it's good for! 😉
And it is FREE!

Features:

Managing tasks like a nagging mother
Managing deadlines (coming soon once the engineers stop throwing bananas)
Reminders (coming soon to computers near you)

Add this into the code to run it!
public class Main { public static void main(String[] args) { Application.launch(MainApp.class, args); } }

Added intro and bye

Added the ability to echo

Used an ArrayList to store list of items

Simplified overall structure. Added an ArrayList as global variable. changed the property of done.

Added documentation to all the functions. Changed the choiceOfAction function such that it can recognize different task. setDate function to create the date String

Changed the structure of the program such that the three task types are all subtask of the main Task

Created a test inputs and outputs

handle errors involving format problems for all three tasks. Exceptions is utilized.

Implement a deleteTask function to remove task when needed

This reverts commit af273dc.

Added 3 functions to save list into file, and then read them upon reopening.

Added in LocalDate and DateTimeFormatter. Changed Deadline and Events Task restrictors as the format has now changed.

ambroseboo · 2021-08-31T09:33:39Z

src/main/java/Duke.java

 public class Duke {
+
+    private String line = "__________________________________\n";


I feel this should be a final field?

It seems that line is a constant. Maybe calling it LINE is more suitable for the coding standard.

ambroseboo · 2021-08-31T09:34:30Z

src/main/java/Duke.java

+         * get isDone
+         * @return
+         */
+        public boolean getIsDone() {


Perhaps this should just be isDone()?

ambroseboo · 2021-08-31T09:35:26Z

src/main/java/Duke.java

+            return output + " )";
+        }
+        /**
+         * modify the task message if done.


I think you should try to capitalise all JavaDocs descriptions.

ambroseboo · 2021-08-31T09:37:09Z

src/main/java/Duke.java

+     * @param input
+     * @return boolean
+     */
+    private boolean choiceOfAction(String input) {


Since this is a function that returns a boolean result, I do feel the naming should be isSetDone or isNewTask.

ambroseboo · 2021-08-31T09:37:57Z

src/main/java/Duke.java

+                writer.write(formatTaskIntoCommands(task));
+            }
+            writer.close();
+        }catch (IOException io) {


Spacing error.

ambroseboo · 2021-08-31T09:40:50Z

src/main/java/Duke.java

+                try {
+                    Task newTask = createTask(input);
+                    addTask(newTask);
+                } catch (TodoException tx) {


I feel that seperating exception for each class is quite unneccesary. Simply a TaskException would be easier to understand.

KelvinSoo

Overall not too many coding standard violations.
The code would look neater in packages.

KelvinSoo · 2021-08-31T10:40:25Z

src/main/java/Duke.java

 public class Duke {
+
+    private String line = "__________________________________\n";


It seems that line is a constant. Maybe calling it LINE is more suitable for the coding standard.

KelvinSoo · 2021-08-31T10:44:22Z

src/main/java/Duke.java

+     */
+    private void greet() {
+            System.out.println(line);
+            String logo = " ____        _        \n"


Would it be better for logo to be declared as a constant?

KelvinSoo · 2021-08-31T10:50:51Z

src/main/java/Duke.java

+                }
+            }
+        }catch (FileNotFoundException f) {
+        }catch(IOException io){


There should be a space before the open curly bracket.

KelvinSoo · 2021-08-31T10:59:39Z

src/main/java/Duke.java

+         */
+        public TodoTasks(String action) throws TodoException{
+            super(action, "[T][] ", TaskTypes.Todo);
+            if (action.split(" ").length < 2){


There should be a space before the curly bracket.

Restructured the entire file to a more OOP structure. Java Doc is also updated.

Create 2 packages, Task and Storage. Subdivide classes into respective public class file.

forgot to add Duke package

Created two Junit Test to test the saving of file, and whether invalid inputs is not saved.

Created a workable Duke.java.jar file

Give users a way to find a task by searching for a keyword. Restructured ChoiceOfAction. Now it only chooses which Action Function to use. New function doneAction, deleteAction and findAction.

Wilfredwongkc

LGTM! Just some nit that is related to coding stnadards to fix

Wilfredwongkc · 2021-09-02T12:32:16Z

src/main/java/Duke/DukeTest.java

+
+public class DukeTest {
+    @Test
+    public void dummyTest(){


Suggested change

public void dummyTest(){

public void dummyTest() {

Maybe can add a space?

Wilfredwongkc · 2021-09-02T12:37:21Z

src/main/java/Storage/Storage.java

@@ -0,0 +1,203 @@
+package Storage;
+
+import java.io.*;


Maybe can list out the things you want to import instead of using a wildcard?

Wilfredwongkc · 2021-09-02T12:39:34Z

src/main/java/Storage/Storage.java

+import Task.EventsException;
+
+public class Storage {
+    private final Parser parser= new Parser();


Suggested change

private final Parser parser= new Parser();

private final Parser PARSER = new Parser();

I think if you are declaring a constant, it needs to be in caps. Also, don't forget the space before the "=".

Wilfredwongkc · 2021-09-02T12:41:51Z

src/main/java/Storage/Storage.java

+
+// deals with making sense of the user command
+class Parser {
+


Don't forget to remove this empty line

Wilfredwongkc · 2021-09-02T12:43:30Z

src/main/java/Duke/DukeTest.java

+
+    @Test
+    public void testInvalidFormat() {
+


Don't forget to remove this empty line too

Changed many functions from TaskList and UI class such that they can return the message as String instead of printing it in the console. Setup the GUI which can print the results.

mistakes were made, this is the actual level 10

This reverts commit 8e28087.

1.Created a fat jar file underout\artifact\ip.jar.

added new function isTaskDuplicate under parser. The program can check if the input value will create a program that is already present in the tasklist

Improved code quality 1. changed multiple if-elseif statement to switch 2. Added new function comments Remove a bug that causes program to print logo instead of parsing the input

Improve code quality

ramapriyan912001

Overall, the work is excellent.
Some methods could be shortened perhaps.
Beyond that, great job!

ramapriyan912001 · 2021-09-13T06:34:42Z

src/main/java/Storage/Storage.java

+    public void getDataInputList(TaskList lst) {
+        try {
+            File f = new File("src/main/java/Duke.txt");
+            if(!f.exists()){
+                f.createNewFile();
+            }
+            FileReader reader = new FileReader(f);
+            BufferedReader br = new BufferedReader(reader);  //creates a buffering character input stream
+            String line;
+            Task curTask;
+
+            while ((line = br.readLine()) != null) {
+                boolean isCurTaskDone = false;
+                String[] data = line.split(" ");
+                int lengthLimit = data.length;
+                String taskData = "";
+
+                if (data[data.length - 1].equals("done")){
+                    isCurTaskDone = true;
+                    lengthLimit -= 1;
+                }
+                try {
+                    for (int i = 0; i < lengthLimit; i++) {
+                        taskData = taskData.concat(data[i] + " ");
+                    }
+                    curTask = parser.createTask(taskData);
+                    if (isCurTaskDone) {
+                        curTask.done();
+                    }
+                    lst.getTaskList().add(curTask);
+                } catch (Exception e) {
+                    System.out.println(e.getLocalizedMessage());
+                }
+            }


The method exceeds 40 lines.
Method could be SLAP-ed harder.

ramapriyan912001 · 2021-09-13T06:35:57Z

src/main/java/Storage/Storage.java

+class TodoTasks extends Task{
+    /**
+     * constructor for Task.
+     *
+     * @param action contains all the information to build a TodoTask.
+     * @throws TodoException if the String action is invalid.
+     */
+    public TodoTasks(String action) throws TodoException {
+        super(action, "[T][] ", TaskTypes.Todo);
+        if (action.split(" ").length < 2){
+            throw new TodoException("OOPS!!! The description of a todo cannot be empty.");
+        }
+    }
+}
+
+class DeadlineTask extends Task{
+    /**
+     * constructor for Task.
+     *
+     * @param action containinf all the data needed for the creation of Deadline Task.
+     * @throws DeadlineException if the String action is invalid.
+     */
+    public DeadlineTask(String action) throws DeadlineException {
+        super(action, "[D][] ", TaskTypes.Deadline);
+        if (action.split("/").length < 2) {
+            throw new DeadlineException("incorrect format for deadline task");
+        }
+        if (action.split("/")[1].split(" ").length < 2) {
+            throw new DeadlineException("incorrect date format for Deadline task");
+        }
+    }
+}
+


Should make these classes in separate java files rather than within another file.

Improved GUI by add different colors to Duke and User DialogBox. Some error seemed to have occurred, reused previous local safed version to remove any errors.

Docs file was previously deleted by mistake

Amended user guide, partially done. Debugged code such that the bug whereby check duplicate function fails to work is resolved.

trial

smoke test done to test jar file validity

Improved syntax, removed the appearance of # in the UG

sj1999-BIT added 13 commits August 28, 2021 20:47

level0

f3eaef6

Added intro and bye

level-1

3ecefd8

Added the ability to echo

Level 2. Add, List

26bfdad

Used an ArrayList to store list of items

Level 3. Mark as Done

6d29c98

Simplified overall structure. Added an ArrayList as global variable. changed the property of done.

Level 4. ToDos, Events, Deadlines

235bf49

Added documentation to all the functions. Changed the choiceOfAction function such that it can recognize different task. setDate function to create the date String

A-Inheritance

ad4240f

Changed the structure of the program such that the three task types are all subtask of the main Task

A-TextUiTesting

6394894

Created a test inputs and outputs

Level 5. Handle Errors and A-Exceptions

bcc3b3a

handle errors involving format problems for all three tasks. Exceptions is utilized.

Level 6. Delete

df7a3c2

Implement a deleteTask function to remove task when needed

shui jie test

af273dc

Revert "shui jie test"

a5841b5

This reverts commit af273dc.

Level 7. Save

0d4c6ad

Added 3 functions to save list into file, and then read them upon reopening.

Level 8. Dates and Times

4145601

Added in LocalDate and DateTimeFormatter. Changed Deadline and Events Task restrictors as the format has now changed.

ambroseboo reviewed Aug 31, 2021

View reviewed changes

KelvinSoo reviewed Aug 31, 2021

View reviewed changes

sj1999-BIT added 6 commits August 31, 2021 21:37

Duke A-MoreOOP: Use More OOP

a5408a7

Restructured the entire file to a more OOP structure. Java Doc is also updated.

Duke A-Packages: Organize into Packages

8a90b85

Create 2 packages, Task and Storage. Subdivide classes into respective public class file.

addition to A-Package

656aa1e

forgot to add Duke package

Duke A-JUnit: Add JUnit Tests

71d28f8

Created two Junit Test to test the saving of file, and whether invalid inputs is not saved.

Duke A-Jar: Create a JAR File

e4acacb

Created a workable Duke.java.jar file

Level 9. Find

7bf0d3b

Give users a way to find a task by searching for a keyword. Restructured ChoiceOfAction. Now it only chooses which Action Function to use. New function doneAction, deleteAction and findAction.

Wilfredwongkc suggested changes Sep 2, 2021

View reviewed changes

sj1999-BIT added 8 commits September 4, 2021 22:41

Duke A-Gradle: Use Gradle

661d574

Duke Level-10: GUI

83dbf07

Changed many functions from TaskList and UI class such that they can return the message as String instead of printing it in the console. Setup the GUI which can print the results.

new changes to level 10

c95f4c6

mistakes were made, this is the actual level 10

gradle issue

8e28087

Revert "gradle issue"

9e8f13c

This reverts commit 8e28087.

gradle issue

82a9b74

jar message

0f66bcb

1.Created a fat jar file underout\artifact\ip.jar.

Created two assertions

cb4d7a5

sj1999-BIT closed this Sep 10, 2021

sj1999-BIT reopened this Sep 10, 2021

sj1999-BIT and others added 7 commits September 12, 2021 10:28

extension check duplicate

4d106ab

added new function isTaskDuplicate under parser. The program can check if the input value will create a program that is already present in the tasklist

C-DetectDuplicates

5670173

added new function isTaskDuplicate under parser. The program can check if the input value will create a program that is already present in the tasklist

Improve code quality

d255b4d

Improved code quality 1. changed multiple if-elseif statement to switch 2. Added new function comments Remove a bug that causes program to print logo instead of parsing the input

Improve code quality

53ad6cb

Improved code quality 1. changed multiple if-elseif statement to switch 2. Added new function comments Remove a bug that causes program to print logo instead of parsing the input

try to merge

01d4f8e

Merge branch 'master' into branch-A-CodeQuality

7a19a12

Merge pull request #4 from sj1999-BIT/branch-A-CodeQuality

8a6f0cb

Improve code quality

ramapriyan912001 reviewed Sep 13, 2021

View reviewed changes

sj1999-BIT and others added 16 commits September 13, 2021 19:02

Improve the GUI and resolved bugs

0f21f57

Improved GUI by add different colors to Duke and User DialogBox. Some error seemed to have occurred, reused previous local safed version to remove any errors.

Merge commit '4d106abb4af3ac8469ad2384c142b5ab998ebdef'

5df14b1

Set theme jekyll-theme-minimal

ebe6dc6

Create index.md

a4cafdc

Merge branch 'master' of https://github.com/sj1999-BIT/ip

8871c55

Add Docs file

27efbf3

Docs file was previously deleted by mistake

Create .gitignore

f5c364c

stepping up user guide

6c1a898

Amended user guide, partially done. Debugged code such that the bug whereby check duplicate function fails to work is resolved.

remove lock files

3b7d30e

trial

Update README.md

fc1578b

Update README.md

9a972d1

Update README.md

3a52ad2

create a new jar file

21223e6

smoke test done to test jar file validity

Update README.md

a676875

Improved syntax, removed the appearance of # in the UG

Update README.md

84bc192

Update index.md

90277b1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Shui Jie] ip #493

[Shui Jie] ip #493

sj1999-BIT commented Aug 28, 2021 •

edited

Loading

ambroseboo Aug 31, 2021

KelvinSoo Aug 31, 2021

ambroseboo Aug 31, 2021

ambroseboo Aug 31, 2021

ambroseboo Aug 31, 2021

ambroseboo Aug 31, 2021

ambroseboo Aug 31, 2021

KelvinSoo left a comment

KelvinSoo Aug 31, 2021

KelvinSoo Aug 31, 2021

KelvinSoo Aug 31, 2021

KelvinSoo Aug 31, 2021

Wilfredwongkc left a comment

Wilfredwongkc Sep 2, 2021

Wilfredwongkc Sep 2, 2021

Wilfredwongkc Sep 2, 2021

Wilfredwongkc Sep 2, 2021

Wilfredwongkc Sep 2, 2021

Wilfredwongkc Sep 2, 2021

Wilfredwongkc Sep 2, 2021

ramapriyan912001 left a comment

ramapriyan912001 Sep 13, 2021

ramapriyan912001 Sep 13, 2021

		public class Duke {

		private String line = "__________________________________\n";

	private final Parser parser= new Parser();
	private final Parser PARSER = new Parser();


		// deals with making sense of the user command
		class Parser {

[Shui Jie] ip #493

Are you sure you want to change the base?

[Shui Jie] ip #493

Conversation

sj1999-BIT commented Aug 28, 2021 • edited Loading

Ultimate Normal Scheduler

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KelvinSoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Wilfredwongkc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ramapriyan912001 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sj1999-BIT commented Aug 28, 2021 •

edited

Loading