Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zhang Yubin] ip #471

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Conversation

Kimowarui
Copy link

@Kimowarui Kimowarui commented Aug 26, 2021

DukePro

“Your mind is for having ideas, not holding them.” – David Allen (source)

DukePro frees your mind of having to remember things you need to do. It's,

  • text-based
  • easy to learn
  • SUPER FAST to use

All you need to do is,

  1. download it from here.
  2. double-click it.
  3. add your tasks.
  4. let it manage your tasks for you 😉

And it is FREE!

Features:

  • Managing tasks
  • Managing deadlines (coming soon)
  • Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Launcher {
    public static void main(String[] args) {
        Application.launch(Main.class, args);
    }
}

Copy link

@justintanyf justintanyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, a really good job!

@@ -0,0 +1,14 @@
public class Deadline extends Task {

protected String by;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be more specific as to what it refers to?


while(!input.equals("bye")) {
String[] parts = input.split(" ");
if(input.equals("list")) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be cleaner to change to switch statements

@@ -0,0 +1,14 @@
public class Event extends Task {

protected String at;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to use a more desceiptive name for the variable

}

public String getStatusIcon() {
return (isDone ? "X" : " "); // mark done task with X

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ternary operators might look cleaner when seperated into multiple lines, and there is no need for the brackets.

task.add(event);
System.out.println("Now you have " + task.size() + " tasks in your list");
System.out.println(line);
} else if (parts[0].equals("todo")){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a space between ")" and "{", so ) {

Copy link

@weichang18 weichang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty good, but it seems like you have not done week 2's task. If you have done so, you should commit it so we can help you review your code.

Comment on lines 33 to 38
int index = Integer.valueOf(parts[1]);
Task thisTask = task.get(index - 1);
thisTask.markDone();
System.out.println(line);
System.out.println("Nice! I've marked this task as done:\n" + thisTask.toString());
System.out.println(line);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for this portion can create an additional class(Example UI) to do all this line of code for you, and just need to call that function from the class so that it looks much neater. Can also be done so on your other if-else statements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants