-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[David Liu] iP #463
base: master
Are you sure you want to change the base?
[David Liu] iP #463
Conversation
# Conflicts: # src/main/java/Deadline.java # src/main/java/Duke.java # src/main/java/Event.java
# Conflicts: # src/main/java/duke/DukeException.java # src/main/java/duke/command/Todo.java
# Conflicts: # src/main/java/duke/task/Task.java # src/main/java/duke/task/TaskList.java # src/main/java/duke/util/Ui.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good effort in keeping to many of the coding standard guidelines and best practices! Only minor commenting and naming errors are found throughout the files. Good job!
thank you for the inputs @nzixuan 😄 i agree with you, ill do the necessary changes 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me!
Important assumptions required for program to work are not checked for. Documenting important assumptions that should hold at various points in the code helps with understanding of code and checks if program is running properly. Let's, * include assert statements to define assumptions about the program state * enable assertions in Gradle run task Integrating with Gradle allows for a smoother workflow in the development process.
Program code can be improved for readability. Critically examining the code and refactoring helps make the code more readable and more easily understood. Let's, * avoid long methods * avoid deep nesting * make the happy path (the execution path taken when everything goes well) prominent * extract methods Refactoring code in such a way helps to make the program execution path and methods clearer to readers.
thank you for the valuable inputs @moreTriangles @kawaiigabrielneko 😃 ill make the relevant changes 👌🏻 |
Duplicate tasks can be added onto the task list. Handling duplicate items helps to keep the task list neat. Let's, * add the ability to recognize duplicate tasks * deal with duplicate tasks when adding to task list Preventing duplicate tasks from being added to task list keeps the task list tidy.
Use Assertions
# Conflicts: # src/main/java/duke/Duke.java
Improve code quality
Deal duplicate items
Calico
Calico frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to use 💯All you need to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's a
main
method example: