Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[David Liu] iP #463

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

[David Liu] iP #463

wants to merge 46 commits into from

Conversation

Kangxun
Copy link

@Kangxun Kangxun commented Aug 25, 2021

Calico

“An idea that is not dangerous is unworthy of being called an idea at all.” – Oscar Wilde (source)

Calico frees your mind of having to remember things you need to do. It's,

  • text-based
  • easy to learn 👍🏻
  • FAST SUPER FAST to use 💯

All you need to do is,

  1. download it from here.
  2. double-click it.
  3. add your tasks.
  4. let it manage your tasks for you 😆

And it is FREE!

Features:

  • Managing tasks
  • Managing deadlines (coming soon)
  • Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's a main method example:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

Copy link

@nzixuan nzixuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good effort in keeping to many of the coding standard guidelines and best practices! Only minor commenting and naming errors are found throughout the files. Good job!

src/main/java/duke/Duke.java Outdated Show resolved Hide resolved
src/main/java/duke/Duke.java Outdated Show resolved Hide resolved
src/main/java/duke/util/Parser.java Outdated Show resolved Hide resolved
@Kangxun
Copy link
Author

Kangxun commented Sep 2, 2021

thank you for the inputs @nzixuan 😄 i agree with you, ill do the necessary changes 👍

Copy link

@adamozh adamozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

src/main/java/duke/Duke.java Outdated Show resolved Hide resolved
src/main/java/duke/command/Deadline.java Outdated Show resolved Hide resolved
src/main/java/duke/util/Storage.java Outdated Show resolved Hide resolved
Copy link

@Smanmos Smanmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

Important assumptions required for program to work are not checked for.

Documenting important assumptions that should hold at various points in the code helps with understanding of code and checks if program is running properly.

Let's,
* include assert statements to define assumptions about the program state
* enable assertions in Gradle run task

Integrating with Gradle allows for a smoother workflow in the development process.
Program code can be improved for readability.

Critically examining the code and refactoring helps make the code more readable and more easily understood.

Let's,
* avoid long methods
* avoid deep nesting
* make the happy path (the execution path taken when everything goes well) prominent
* extract methods

Refactoring code in such a way helps to make the program execution path and methods clearer to readers.
@Kangxun
Copy link
Author

Kangxun commented Sep 8, 2021

thank you for the valuable inputs @moreTriangles @kawaiigabrielneko 😃 ill make the relevant changes 👌🏻

Duplicate tasks can be added onto the task list.

Handling duplicate items helps to keep the task list neat.

Let's,
* add the ability to recognize duplicate tasks
* deal with duplicate tasks when adding to task list

Preventing duplicate tasks from being added to task list keeps the task list tidy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants