Skip to content

Commit

Permalink
fixed incorrect SNAPSHOT version checking logic for check operation
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickcrocker committed Oct 3, 2017
1 parent 5fc9d97 commit ce13b44
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
## 1.3.4 - 2017-10-03
### Fixed
- v1.3.3 introduced [Incorrect SNAPSHOT version checking logic](https://github.com/patrickcrocker/maven-resource/issues/12) for the `check` operation for snapshots but was quickly spotted by [@shinmyung0](https://github.com/shinmyung0). This is now fixed and the 1.3.3 release has been yanked!

### Removed
- Version 1.3.3 (use 1.3.4 instead!!)

## 1.3.3 - 2017-10-03
## 1.3.3 - 2017-10-03 [YANKED]
### Added
- Change log file (CHANGELOG.md).
- Generate release notes from CHANGELOG.me for github release (pipeline.yml).
Expand Down
2 changes: 1 addition & 1 deletion assets/in
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ fi

# test for 1.0.0-SNAPSHOT and for 1.0.0-20170328.031519-19
isSnapshot=false
[[ "$version" = *-SNAPSHOT ]] && echo "$version" | grep -oEq "[0-9]{8}\.[0-9]{6}-[0-9]{1,}" && isSnapshot=true
[[ "$version" = *-SNAPSHOT ]] || echo "$version" | grep -oEq "[0-9]{8}\.[0-9]{6}-[0-9]{1,}" && isSnapshot=true

url=$release_url
[ -n "$snapshot_url" ] && [ "$isSnapshot" = true ] && url=$snapshot_url
Expand Down

0 comments on commit ce13b44

Please sign in to comment.