New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrub #481

Merged

funwithtriangles merged 2 commits into alpha from fix-scrub

Jan 3, 2025

Member

funwithtriangles commented Jan 3, 2025

Scrubbing wasn't working. This was because getParamWithInfo was causing lots of re-renders.

Now using useShallow to prevent re-renders
Using useCallback so that onElementScrub isn't constantly being created

funwithtriangles added 2 commits

January 3, 2025 16:57


          fixed scrub issue

f83e316


          react optimisation

98ee08c

funwithtriangles merged commit 2df3b1e into alpha

1 check passed

funwithtriangles deleted the fix-scrub branch

January 3, 2025 16:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet