Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrackNamespaceManager #103

Merged

Conversation

tetter27
Copy link
Collaborator

@tetter27 tetter27 commented Oct 7, 2024

Changes

  • Name changed: TrackNamespaceManager -> PubSubRelationManager
  • Refactored the folder structure and the model for pubsub management
  • Supported Subscribe ID and Track Alias (Relay side only)
  • Changed processes around PubSubRelationManager in message handlers
  • Fulfilled almost all processes in new functions with unit tests.

TODO

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 90.45699% with 71 lines in your changes missing coverage. Please review.

Project coverage is 77.37%. Comparing base (e8b18dc) to head (01e87a8).
Report is 21 commits behind head on impl/subscribe_id_and_track_alias.

Additional details and impacted files
@@                          Coverage Diff                          @@
##           impl/subscribe_id_and_track_alias     #103      +/-   ##
=====================================================================
+ Coverage                              74.18%   77.37%   +3.19%     
=====================================================================
  Files                                     39       45       +6     
  Lines                                   1445     1830     +385     
=====================================================================
+ Hits                                    1072     1416     +344     
- Misses                                   373      414      +41     
Components Coverage Δ
moqt-core 91.91% <96.52%> (+1.10%) ⬆️
moqt-server 66.15% <87.74%> (+3.54%) ⬆️

@yuki-uchida yuki-uchida merged commit 99731d1 into impl/subscribe_id_and_track_alias Oct 10, 2024
9 checks passed
@yuki-uchida yuki-uchida deleted the impl/track_namespace_manager branch October 10, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants