-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TrackNamespaceManager #103
Merged
yuki-uchida
merged 19 commits into
impl/subscribe_id_and_track_alias
from
impl/track_namespace_manager
Oct 10, 2024
Merged
Update TrackNamespaceManager #103
yuki-uchida
merged 19 commits into
impl/subscribe_id_and_track_alias
from
impl/track_namespace_manager
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## impl/subscribe_id_and_track_alias #103 +/- ##
=====================================================================
+ Coverage 74.18% 77.37% +3.19%
=====================================================================
Files 39 45 +6
Lines 1445 1830 +385
=====================================================================
+ Hits 1072 1416 +344
- Misses 373 414 +41
|
This was referenced Oct 7, 2024
yuki-uchida
requested changes
Oct 9, 2024
moqt-core/src/modules/messages/control_messages/subscribe_ok.rs
Outdated
Show resolved
Hide resolved
moqt-core/src/modules/subscription_models/nodes/consumer_node.rs
Outdated
Show resolved
Hide resolved
yuki-uchida
approved these changes
Oct 10, 2024
yuki-uchida
merged commit Oct 10, 2024
99731d1
into
impl/subscribe_id_and_track_alias
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TrackNamespaceManager
->PubSubRelationManager
TODO