Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/mss v3 #50

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Dev/mss v3 #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2883bdc
IF-10358 Support MSS v3 (#43)
ikegami-shota May 17, 2024
7d42827
Merge branch 'master' into dev/MSS_v3
ikegami-shota May 30, 2024
cf7b344
IF-10358 Rebase Managed Load Balancer Support
ikegami-shota May 17, 2024
cc6337b
Managed Load Balancer support incorporated into v4
ikegami-shota May 30, 2024
44d6aaa
Merge differences with remote
ikegami-shota May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 6 additions & 6 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ way than just downloading it. Here are the basic instructions:
[README](/README.md#how-to-install).

```bash
go get github.com/nttcom/eclcloud/v2
go get github.com/nttcom/eclcloud/v3
```

2. Move into the directory that houses your local repository:

```bash
cd ${GOPATH}/src/github.com/nttcom/eclcloud/v2
cd ${GOPATH}/src/github.com/nttcom/eclcloud/v3
```

3. Fork the `nttcom/eclcloud` repository and update your remote refs. You
Expand Down Expand Up @@ -130,7 +130,7 @@ process of testing expectations with assertions:
import (
"testing"

"github.com/nttcom/eclcloud/v2/testhelper"
"github.com/nttcom/eclcloud/v3/testhelper"
)

func TestSomething(t *testing.T) {
Expand All @@ -156,9 +156,9 @@ Here is a truncated example of mocked HTTP responses:
import (
"testing"

th "github.com/nttcom/eclcloud/v2/testhelper"
fake "github.com/nttcom/eclcloud/v2/testhelper/client"
"github.com/nttcom/eclcloud/v2/ecl/network/v2/networks"
th "github.com/nttcom/eclcloud/v3/testhelper"
fake "github.com/nttcom/eclcloud/v3/testhelper/client"
"github.com/nttcom/eclcloud/v3/ecl/network/v2/networks"
)

func TestGet(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ fmtcheck:
(! gofmt -s -d . | grep '^')

vet:
go vet ./... && cd v2 && go vet ./...
go vet ./... && cd v2 && go vet ./... && cd ../v3 && go vet ./... && cd ../v4 && go vet ./...

test:
go test ./... -count=1 && cd v2 && go test ./... -count=1
go test ./... -count=1 && cd v2 && go test ./... -count=1 && cd ../v3 && go test ./... -count=1 && cd ../v4 && go test ./... -count=1

.PHONY: fmt fmtcheck vet test
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ explicitly, or tell eclcloud to use environment variables:

```go
import (
"github.com/nttcom/eclcloud/v2"
"github.com/nttcom/eclcloud/v2"
"github.com/nttcom/eclcloud/v2/utils"
"github.com/nttcom/eclcloud/v3"
"github.com/nttcom/eclcloud/v3"
"github.com/nttcom/eclcloud/v3/utils"
)

// Option 1: Pass in the values yourself
Expand Down Expand Up @@ -82,7 +82,7 @@ in the flavor ID (hardware specification) and image ID (operating system) we're
interested in:

```go
import "github.com/nttcom/eclcloud/v2/compute/v2/servers"
import "github.com/nttcom/eclcloud/v3/compute/v2/servers"

server, err := servers.Create(client, servers.CreateOpts{
Name: "My new server!",
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/nttcom/eclcloud

go 1.13
go 1.17
2 changes: 1 addition & 1 deletion v2/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/nttcom/eclcloud/v2

go 1.13
go 1.17
Loading
Loading