Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up eslint #69

Merged
merged 1 commit into from
Jul 11, 2021
Merged

chore: set up eslint #69

merged 1 commit into from
Jul 11, 2021

Conversation

hydrosquall
Copy link
Member

Motivation

Changes

  • Adds eslint, @typescript-eslint/eslint-plugin, and @typescript-eslint/eslint-plugin

Testing

  • This should have no impact on existing code, this is a DX improvement for subsequent updates.

Notes

  • The output of yarn run format and yarn run lint can be saved for a follow-up PR.
  • yarn run lint prints out a swath of unused variables that can be addressed in a follow-up PR.

@hydrosquall hydrosquall added the chore Chore or quality of life improvement label Jul 4, 2021
@hydrosquall hydrosquall self-assigned this Jul 4, 2021
@hydrosquall hydrosquall added the dependencies Update one or more dependencies version label Jul 4, 2021
@hydrosquall hydrosquall force-pushed the cameron.yick/set-up-eslint-stage branch from 72ac0c4 to a5a562b Compare July 6, 2021 23:44
@hydrosquall
Copy link
Member Author

Confirmed this is OK to merge in the nteract slack w/ @willingc , as it falls into the category of a minor testing/tooling change.

@hydrosquall hydrosquall merged commit 620e620 into main Jul 11, 2021
@github-actions
Copy link

🚀 PR was released in v8.2.12 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore or quality of life improvement dependencies Update one or more dependencies version released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant