Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly display complex datatypes (objects) in table cells #65

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Jun 29, 2021

Motivation

Changes

  • Assuming that the input schema is typed correctly, stringify object columns before displaying them. (Arrays are a subset of objects).
  • Made Typescript types a bit stricter to guard against this type of issue in the future: 64f9565

Testing

Future steps

📦 Published PR as canary version: 8.2.10--canary.65.4b3f411.0

✨ Test out this PR locally via:

npm install @nteract/[email protected]
# or 
yarn add @nteract/[email protected]

@hydrosquall hydrosquall added the release Create a release when this pr is merged label Jun 29, 2021
@hydrosquall hydrosquall self-assigned this Jun 29, 2021
@hydrosquall hydrosquall requested a review from emeeks June 30, 2021 23:09
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @hydrosquall. Feel free to merge.

@hydrosquall
Copy link
Member Author

Thanks @willingc ! I'll merge now, but am happy to revisit if @emeeks has concerns in the future.

Would you happen to know where is the python code we'd need to modify to get the upstream code to set the pandas schema type to object instead of string for dataframes like what was reported in the original issue?

I took a look at the source code for dx, but couldn't figure out how the frictionless data schema is being produced.

@hydrosquall hydrosquall merged commit db0f607 into main Jul 1, 2021
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

🚀 PR was released in v8.2.11 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 1, 2021
@hydrosquall hydrosquall deleted the cameron.yick/fix-object-in-table-cell branch July 1, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Explorer breaks when dataframe cell has complex data in it
2 participants