Added in a close() method for the nsq Reader. It closes all connections ... #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and stops all PeriodicCallbacks. To close those callbacks, the _run() method needed to be updated so that we could keep track of them.
|
This is a first stab at a close functionality for the Reader. I expect that there are some gaps in steps needed. Relevant to, but not the full solution to #70 |
|
I was only planning on adding this to the reader. It's an itch I needed to scratch for a work project. However, if this is merged in I can take a look as to what goes into the rest of #70 this weekend. Then I'll give it a shot and open a new pull request for it. |
|
OK, fair enough - would be great to finish up the rest of #70 if you're interested! This LGTM |
mreiferson
added a commit
that referenced
this pull request
Oct 13, 2014
Added in a close() method for the nsq Reader. It closes all connections ...
|
Thanks ✨ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and stops all PeriodicCallbacks. To close those callbacks, the _run() method needed to be updated so that we could keep track of them.