netmap: add GetAttributes and SetAttributes for NodeInfo
#635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
cthulhu-rider,
smallhive and
carpawell
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
==========================================
+ Coverage 56.33% 56.34% +0.01%
==========================================
Files 164 164
Lines 22403 22420 +17
==========================================
+ Hits 12620 12633 +13
- Misses 9396 9400 +4
Partials 387 387 ☔ View full report in Codecov by Sentry. |
carpawell
requested changes
Nov 14, 2024
End-rey
force-pushed
the
node-info-set-get-attributes
branch
from
729be9c
to
bfd0121
Compare
End-rey
force-pushed
the
node-info-set-get-attributes
branch
from
bfd0121
to
e6979b9
Compare
roman-khimov
approved these changes
Nov 15, 2024
cthulhu-rider
approved these changes
Nov 15, 2024
netmap/node_info_test.go
Outdated
| require.Equal(t, attr2[1], n.Attribute(k2)) | ||
| require.Equal(t, 2, n.NumberOfAttributes()) | ||
|
|
||
| n.SetAttributes() |
There was a problem hiding this comment.
essentially this is a reset API which code seems a bit strange to me. I'd replace variadic parameter with a slice. At the same time, passing individual items like few lines above look a bit nicer w/o slicing. But i still stand for slice prm, but dont insist
There was a problem hiding this comment.
i am also for slice, but do not insist
netmap/node_info_test.go
Outdated
| require.Equal(t, 2, n.NumberOfAttributes()) | ||
|
|
||
| n.SetAttributes() | ||
| require.Equal(t, 0, n.NumberOfAttributes()) |
netmap/node_info_test.go
Outdated
|
|
||
| n.SetAttributes(attr1) | ||
| attrs := n.GetAttributes() | ||
| require.Equal(t, len(attrs), n.NumberOfAttributes()) |
There was a problem hiding this comment.
Suggested change
| require.Equal(t, len(attrs), n.NumberOfAttributes()) | |
| require.Len(t, attrs, 1) |
netmap/node_info_test.go
Outdated
|
|
||
| n.SetAttributes(attr1, attr2) | ||
| attrs = n.GetAttributes() | ||
| require.Equal(t, len(attrs), n.NumberOfAttributes()) |
There was a problem hiding this comment.
Suggested change
| require.Equal(t, len(attrs), n.NumberOfAttributes()) | |
| require.Len(t, attrs, 2) |
carpawell
approved these changes
Nov 15, 2024
netmap/node_info_test.go
Outdated
| require.Equal(t, attr2[1], n.Attribute(k2)) | ||
| require.Equal(t, 2, n.NumberOfAttributes()) | ||
|
|
||
| n.SetAttributes() |
There was a problem hiding this comment.
i am also for slice, but do not insist
Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
node-info-set-get-attributes
branch
from
e6979b9
to
41a43d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs nspcc-dev/neofs-node#3005 (comment).
I'm not sure about taking out
netmap.Attribute. Maybe I need to create my own Attribute?