Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: release RC10 #484

Merged
merged 1 commit into from
Aug 4, 2023
Merged

CHANGELOG: release RC10 #484

merged 1 commit into from
Aug 4, 2023

Conversation

roman-khimov
Copy link
Member

No description provided.

@roman-khimov roman-khimov added this to the v1.0.0-rc10 milestone Aug 4, 2023
@carpawell
Copy link
Member

Has the Slicer been checked?

@roman-khimov
Copy link
Member Author

Yup, @smallhive has at least two projects converted now and yeah, there were #481 and #482.

@carpawell
Copy link
Member

@roman-khimov, the last Slicer release was kinda OK for the gates but also awful for the node so that is why I am asking.

@cthulhu-rider
Copy link
Contributor

current Slicer isn't very tasty for the node (previous generic ObjectWriter was more appropriate than current client-like interface), but it works and requires pretty small adoptions

carpawell
carpawell reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider RC10 as a real stable RC

Old pool APIs are availabe in this release

Confuse me. Although, the full text is understandable for sure.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md
* automatic session creation/use can be disabled for Pool now (#454)

Behaviour changes:
* `container` package APIs using Container struct are now methods of the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you define what to backtick?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually trying to avoid misunderstandings, "Container" is OK unquoted, "container" not so much.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and what about Pool but "client's ObjectWriter" and "interface can work with both Client and Pool now"? i'm ok if there is some rule. but i do not see it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client is a struct, just like Pool is. client is a package. "client's" looks awful, client's is incorrect, therefore "client's"

@roman-khimov
CHANGELOG: release RC10
d3c7324 
Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov roman-khimov merged commit 8e843fe into master Aug 4, 2023
1 check passed
@roman-khimov roman-khimov deleted the rel-rc10 branch August 4, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@carpawell carpawell carpawell approved these changes

@smallhive smallhive Awaiting requested review from smallhive smallhive is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0-rc10
Development

Successfully merging this pull request may close these issues.
3 participants
@roman-khimov @carpawell @cthulhu-rider