Fix/Placement sorting #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Karpy <[email protected]>
carpawell
requested review from
roman-khimov,
cthulhu-rider and
smallhive
as code owners
roman-khimov
approved these changes
Jul 31, 2023
carpawell
force-pushed
the
fix/placement-sorting
branch
from
f03943b
to
a14def0
Compare
|
Fixed the tests, see the last commit. |
carpawell
force-pushed
the
fix/placement-sorting
branch
from
a14def0
to
5da1aac
Compare
|
Woops, wrong push. |
Do not return next element if `0` is being facing. Also, add a public key to the test nodes. It is used in `Hash()` method and, therefore, is the main start point in the HWR sorting, without it, every node is considered the same, so it is hard to pick a good test value, cause sorting is random for the same hashes. Closes nspcc-dev#438. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/placement-sorting
branch
from
5da1aac
to
6e3c516
Compare
smallhive
approved these changes
Aug 1, 2023
roman-khimov
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #438.