-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated code for 0.107.0 #3690
base: master
Are you sure you want to change the base?
Conversation
A part of #3454. Signed-off-by: Roman Khimov <[email protected]>
A part of #3454. Signed-off-by: Roman Khimov <[email protected]>
A part of #3454. Signed-off-by: Roman Khimov <[email protected]>
A part of #3454. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3690 +/- ##
==========================================
+ Coverage 82.98% 83.12% +0.13%
==========================================
Files 334 334
Lines 46603 46543 -60
==========================================
+ Hits 38672 38687 +15
+ Misses 6355 6283 -72
+ Partials 1576 1573 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Removal of the `Dump*Slot()` methods are scheduled for the 0.108.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but we have a broken text file. I've postponed this change to the last commit and can make it a separate one if you wish.
A part of #3454 for 0.107.0 release. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
7db189e
to
3f1ccdd
Compare
Fixes #3454.