Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated code for 0.107.0 #3690

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

roman-khimov
Copy link
Member

Fixes #3454.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.12%. Comparing base (2b1b9a4) to head (3f1ccdd).

Files with missing lines Patch % Lines
pkg/core/state/native_state.go 60.00% 1 Missing and 1 partial ⚠️
pkg/rpcclient/waiter/waiter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3690      +/-   ##
==========================================
+ Coverage   82.98%   83.12%   +0.13%     
==========================================
  Files         334      334              
  Lines       46603    46543      -60     
==========================================
+ Hits        38672    38687      +15     
+ Misses       6355     6283      -72     
+ Partials     1576     1573       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Removal of the `Dump*Slot()` methods are scheduled for the 0.108.0 release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but we have a broken text file. I've postponed this change to the last commit and can make it a separate one if you wish.

A part of #3454 for 0.107.0 release.

Signed-off-by: Roman Khimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated functionality
2 participants