Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: fix skip-blocks-uploading mode #3686

Merged
merged 2 commits into from
Nov 15, 2024
Merged

cli: fix skip-blocks-uploading mode #3686

merged 2 commits into from
Nov 15, 2024

Conversation

AliceInHunterland
Copy link
Contributor

If uploadBlocks succeeded uploadIndexFiles should work based on the current block height.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.06%. Comparing base (b97d0b2) to head (5f6284d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cli/util/upload_bin.go 3.03% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3686      +/-   ##
==========================================
+ Coverage   83.04%   83.06%   +0.02%     
==========================================
  Files         334      334              
  Lines       46613    46629      +16     
==========================================
+ Hits        38708    38733      +25     
+ Misses       6333     6317      -16     
- Partials     1572     1579       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cli/util/convert.go Outdated Show resolved Hide resolved
cli/util/convert.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
If uploadBlocks succeeded uploadIndexFiles should work based on the
currentBlockHeight.

Signed-off-by: Ekaterina Pavlova <[email protected]>
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple.

@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone Nov 15, 2024
@AnnaShaleva AnnaShaleva added bug Something isn't working cli Command line interface labels Nov 15, 2024
@AnnaShaleva AnnaShaleva merged commit 4a96bd1 into master Nov 15, 2024
33 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the fix-mode branch November 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Command line interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants